Re: [evolution-patches] Cleanups for e-d-s/libedataserverui

[chenthill <pchenthill novell com>]

Hi kmaraas,

On Wed, 2006-08-16 at 17:27 +0200, Kjartan Maraas wrote:
> gtk_tree_view_get_dest_row_at_pos(GTK_TREE_VIEW (list->tree_view),
> event->x, event->y, &path, &pos);
>         selection = gtk_tree_view_get_selection 
Since the pos is not used anywhere, NULL could be passed in place of
&pos.

int noreply = msg->noreply;
The type of noreply should be changed in e-passwords.c (ep_ask_password)
and (pass_response) since the type has been changed in the _EPassMsg
structure.

The rest of it looks good.

While reviewing this patch, i found there are still some more warnings
e-name-selector-entry.c: In function 'user_delete_text':
e-name-selector-entry.c:1156: warning: comparison between pointer and
integer
e-name-selector-entry.c:1231: warning: label 'end_of_user_delete_text'
defined but not used
e-name-selector-entry.c: In function 'e_name_selector_entry_init':
e-name-selector-entry.c:2091: warning: suggest parentheses around
assignment used as truth value.
It would be nice if you could add a fix for these also.

thanks, Chenthill.