Re: [Fwd: [evolution-patches] Patch for bug 311063 (mail)]



Parthasarathi Susarla wrote:
On Fri, 2005-09-30 at 10:15 +0530, Sarfraaz Ahmed wrote:
  
On Wed, 2005-09-28 at 13:48 -0700, Carsten Guenther wrote:
    
Ok, I closed 311063 as invalid and opened a new one:
    http://bugzilla.gnome.org/show_bug.cgi?id=317466

Attached patch fixes the problem by not showing the location-pick dialog 
for search folders therefore not allowing nested search folders and 
removing the confusion between search and regular folders.
      
I havent seen your patch well, but from the bug you pasted above, looks
like a proper solution would be to leave, "New Folder" do what it does
today, but disable it on the "Search Folders" tree. And instead, have a
new popup menu item called "New Search Folder" or somesuch which pops up
the search folder editor. Make sure that you disable this new item for
non-search folder hierarchies.
    

I should say i second sarfraaz thoughts on this. The right fix for this
would be have a New Search folder option, with the properties as
mentioned by sarf.

OK. I agree with the issue with nested Search folders. That should not
be allowed.

So if you could rework on the patch to do this, would be fine.

Cheers,
partha
  
My patch does that, except that it does not rename "New Folder" to "New Search Folder".

We also need to prevent drag-and-drop of search folders. I will send out a revised patch later, probably next week.

Thanks for the comments,
Carsten


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]