Re: [evolution-patches] exchange : patch for #314746

[Sarfraaz Ahmed <asarfraaz novell com>]

Thanks for the review. Modified and commit to both the branches.

-- Sarfraaz

On Wed, 2005-09-28 at 16:14 +0530, Arunprakash wrote:
> Hi,
> 
> Wouldn't it be nice to put the debug printfs in d()s?
> 
> > +	foreign_uri = strchr (foreign_uri + 3, '/');
> > +	if (!foreign_uri)
> > +		goto cleanup;
> > +
> > +	if ((foreign_uri + 1) && (*(foreign_uri + 1) == ';'))
> > +		goto cleanup;
> > +
> > +	new_phy_uri = g_strdup_printf ("exchange://%s/;%s", account_uri, foreign_uri + 1);
> > +	g_hash_table_steal (old_props, "physical_uri_prefix");
> 
> Aren't the key and value leaked?
> 
> > +	g_hash_table_insert (old_props, (char *)g_strdup ("physical_uri_prefix"), new_phy_uri);
> > +
> > +	new_doc = e_xml_from_hash (old_props, E_XML_HASH_TYPE_PROPERTY, "foreign-hierarchy");
> > +	xmlSaveFile (file_path, new_doc);
> > +
> > +	xmlFreeDoc (new_doc);
> > +	g_free (new_phy_uri);
> 
> 
> 
> > @@ -2056,16 +2059,24 @@ exchange_account_new (EAccountList *acco
> >  
> >  	/* URI, etc, info */
> >  	enc_user = e2k_uri_encode (uri->user, FALSE, "@/;:");
> > -	account->priv->uri_authority = g_strdup_printf ("%s %s", enc_user,
> > +	old_uri_authority = g_strdup_printf ("%s %s", enc_user,
> >  							uri->host);
> 
> old_uri_authority has to be freed.
> 
> > +	if (uri->authmech)
> > +		account->priv->uri_authority = g_strdup_printf ("%s;auth=%s %s", enc_user,
> > +								uri->authmech, uri->host);
> > +	else
> > +		account->priv->uri_authority = g_strdup_printf ("%s %s", enc_user,
> > +								uri->host);
> >  	g_free (enc_user);
> 
> Rest is fine.
> 
> Thanks,
> Arunprakash.
> 
>