Re: [evolution-patches] Patch for 316351 (e-table's accessibility related)

[Parthasarathi Susarla <sparthasarathi novell com>]

Looks fine.

Thanks,
partha

On Tue, 2005-09-27 at 13:24 +0800, Harry Lu wrote:
> Hi,
>     Attached is a patch for e-table's accessibility's bug:
> http://bugzilla.gnome.org/show_bug.cgi?id=316351
> 
>     jpremkumar novell com has verified this patch can fix the problem. 
> Please review it. I want to commit it into both gnome-2-12 branch and HEAD.
>     Thanks!
>        Harry
> plain text document attachment (cell.diff)
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/a11y/ChangeLog,v
> retrieving revision 1.43
> diff -u -r1.43 ChangeLog
> --- ChangeLog	17 Aug 2005 06:35:19 -0000	1.43
> +++ ChangeLog	27 Sep 2005 05:16:49 -0000
> @@ -1,3 +1,11 @@
> +2005-09-27  Harry Lu <harry lu sun com>
> +
> +	Fix for #316351
> +
> +	* e-table/gal-a11y-e-cell.c: (idle_do_action),
> +	(gal_a11y_e_cell_action_do_action): add a ref/unref pair to make
> +	sure the pointer is valid.
> +
>  2005-08-15  Li Yuan  <li yuan sun com>
>  
>  	* e-table/gal-a11y-e-table-item.c: (eti_a11y_reset_focus_object):
> Index: e-table/gal-a11y-e-cell.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/a11y/e-table/gal-a11y-e-cell.c,v
> retrieving revision 1.13
> diff -u -r1.13 gal-a11y-e-cell.c
> --- e-table/gal-a11y-e-cell.c	17 Jun 2005 15:20:24 -0000	1.13
> +++ e-table/gal-a11y-e-cell.c	27 Sep 2005 05:16:51 -0000
> @@ -423,6 +423,7 @@
>  
>  	cell->action_idle_handler = 0;
>  	cell->action_func (cell);
> +	g_object_unref (cell);
>                                                                                  
>  	return FALSE;
>  }
> @@ -443,6 +444,7 @@
>  	if (cell->action_idle_handler)
>  		return FALSE;
>  	cell->action_func = info->do_action_func;
> +	g_object_ref (cell);
>  	cell->action_idle_handler = g_idle_add (idle_do_action, cell);
>  
>  	return TRUE;
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches