[evolution-patches] [addressbook] Patch for Bug 271777: Overaggresive Auto Complete

[Devashish <sdevashish novell com>]

Hi,


Suppose your addressbook has a contact "Joel Smith <joel smith com>" and
u wish to send an email to "joe ximian com". U type in joe and it gets
replaced with "Joel Smith <joel smith com>", Now u keep on typing and
end up with Joe ximian com which is not the correct address.

This is happening because of type_ahead_complete, which searches for the best
matching contact among all the matching contacts and replaces whatever u have written
with this contact.

So commenting out the code for invoking type_ahead_complete to resolve this.


Thanks
Devashish Sharma

Index: libedataserverui/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/libedataserverui/ChangeLog,v
retrieving revision 1.62
diff -u -p -r1.62 ChangeLog
--- libedataserverui/ChangeLog	26 Aug 2005 11:44:47 -0000	1.62
+++ libedataserverui/ChangeLog	26 Sep 2005 14:33:02 -0000
@@ -1,3 +1,9 @@
+2005-09-26  Devashish Sharma <sdevashish novell com>
+
+	* e-name-selector-entry.c (user_insert_text): Commented out the code
+	for type_ahead_complete. See the following bug for more detail.
+	Fixes #271777
+
 2005-08-26  Harish Krishnaswamy  <kharish novell com>
 
 	* e-name-selector-dialog.c: (e_name_selector_dialog_init):
Index: libedataserverui/e-name-selector-entry.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-name-selector-entry.c,v
retrieving revision 1.25
diff -u -p -r1.25 e-name-selector-entry.c
--- libedataserverui/e-name-selector-entry.c	31 Aug 2005 04:26:10 -0000	1.25
+++ libedataserverui/e-name-selector-entry.c	26 Sep 2005 14:34:09 -0000
@@ -1087,12 +1087,11 @@ user_insert_text (ENameSelectorEntry *na
 				g_idle_add ((GSourceFunc) update_completions_on_idle_cb,
 					    name_selector_entry);
 		}
-
-		if (!name_selector_entry->type_ahead_complete_cb_id) {
+		/*if (!name_selector_entry->type_ahead_complete_cb_id) {
 			name_selector_entry->type_ahead_complete_cb_id =
 				g_idle_add ((GSourceFunc) type_ahead_complete_on_idle_cb,
 					    name_selector_entry);
-		}
+		}*/
 	} else if (chars_inserted > 1 && name_selector_entry->type_ahead_complete_cb_id) {
 		/* If the user inserted more than one character, prevent completion */
 		g_source_remove (name_selector_entry->type_ahead_complete_cb_id);
@@ -1385,8 +1384,8 @@ setup_contact_store (ENameSelectorEntry 
 						GTK_TREE_MODEL (name_selector_entry->email_generator));
 
 		/* Set up callback for incoming matches */
-		g_signal_connect_swapped (name_selector_entry->contact_store, "row-inserted",
-					  G_CALLBACK (ensure_type_ahead_complete_on_idle), name_selector_entry);
+		/*g_signal_connect_swapped (name_selector_entry->contact_store, "row-inserted",
+					   G_CALLBACK (ensure_type_ahead_complete_on_idle), name_selector_entry);*/
 	} else {
 		/* Remove the store from the entry completion */