Re: [evolution-patches][calendar] fix for incorrect invocation of get_builtin_timezone function in icalcomponent.c(libical)



Shiying Irene Huang wrote:

hi, evolution calendar maintainers

I spotted a mistake in the icalcomponent_get_datetime function in which icaltimezone_get_builtin_timezone_from_tzid(tzid) should be called instead of icaltimezone_get_builtin_timezone(tzid) which intends to retrive the time zone information from tz instead of tzid.

sorry for the mistake here. Calling icaltimezone_get_builtin_timezone is not proper for retrieving timezone information from tzid since it returns the timezone with its Olson city name. Hence, icaltimezone_get_builtin_timezone_from_tzid is more suitable in this occasion.



The attatched is a simple patch for this bug, please review.

Thanks

Irene Huang

------------------------------------------------------------------------

Index: calendar/libical/ChangeLog
===================================================================
RCS file: /cvs/gnome/libical/ChangeLog,v
retrieving revision 1.174.2.1
diff -u -r1.174.2.1 ChangeLog
--- calendar/libical/ChangeLog	5 Sep 2005 05:04:31 -0000	1.174.2.1
+++ calendar/libical/ChangeLog	19 Sep 2005 11:04:57 -0000
@@ -1,3 +1,7 @@
+2005-09-19  garnome  <set EMAIL_ADDRESS environment variable>
+
+ * src/libical/icalcomponent.c: (icalcomponent_get_datetime): icaltimezone_get_builtin_timezone(tzid) was replaced by icaltimezone_get_builtin_timezone_from_tzid(tzid), which is the correct function to retrive timezone information from tzid. +
2005-09-05  P. S. Chakravarthi <pchakravarthi novell com>

	Fixes #312462
Index: calendar/libical/src/libical/icalcomponent.c
===================================================================
RCS file: /cvs/gnome/libical/src/libical/icalcomponent.c,v
retrieving revision 1.27
diff -u -r1.27 icalcomponent.c
--- calendar/libical/src/libical/icalcomponent.c	21 Oct 2003 18:28:29 -0000	1.27
+++ calendar/libical/src/libical/icalcomponent.c	19 Sep 2005 11:05:03 -0000
@@ -1532,7 +1532,7 @@
	}

	if (tz == NULL)
-	    tz = icaltimezone_get_builtin_timezone(tzid);
+	    tz = icaltimezone_get_builtin_timezone_from_tzid(tzid);

	if (tz != NULL)
	    ret = icaltime_set_timezone(&ret, tz);
------------------------------------------------------------------------

_______________________________________________
Evolution-patches mailing list
Evolution-patches gnome org
http://mail.gnome.org/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]