Re: [evolution-patches] Exchange, fixes #312886
- From: Sarfraaz Ahmed <asarfraaz novell com>
- To: Arunprakash <arunp novell com>
- Cc: evolution-patches <evolution-patches gnome org>
- Subject: Re: [evolution-patches] Exchange, fixes #312886
- Date: Thu, 15 Sep 2005 17:11:20 +0530
Looks good. Some styling issues. Just drop the flower braces in the if
clause, since its just a single line anyway. The guidelines are to use
the braces only if atleast one of the if clause has more than one line.
Commit it to the branch and HEAD.
Thanks
-- Sarfraaz
> char *folder_name, *folder_size;
> +
> + service = CAMEL_SERVICE (camel_folder_get_parent_store
> (cml_folder));
> + if (!service) {
This brace is not necessary
> + return NULL;
> + }
> + provider = camel_service_get_provider (service);
> + if (!provider) {
Similar
> + return NULL;
> + }
> + if (g_ascii_strcasecmp (provider->protocol, "exchange")) {
Similar
> + return NULL;
> + }
>
> folder_name = (char*) camel_folder_get_name (cml_folder);
> if (!folder_name)
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]