Re: [evolution-patches][connector] fix for bug #316274

[Sarfraaz Ahmed <asarfraaz novell com>]

Hi,

The e-d-s part looks good. In the evolution plugin code, we need to add
the label packing code also into the ifdef part as shown below. Also,
please mention the bug id in both the ChangeLogs.

These patches look good otherwise, and make sure that you commit them to
the HEAD and the gnome-2-12 branch.

Thanks
-- Sarfraaz

>         /* Add items to the table */
>         gtk_table_attach_defaults (tbl_auth, GTK_WIDGET (lbl_chpass),
> 0, 1, 0, 1);

Add this also ^^^^^ inside the ifdef part.

> +#ifdef HAVE_KRB5
>         gtk_table_attach (tbl_auth, GTK_WIDGET (btn_chpass), 1, 2, 0,
> 1, GTK_FILL, GTK_FILL, 0, 0);
> +#endif
>         gtk_table_attach_defaults (tbl_auth, GTK_WIDGET (lbl_dass), 0,
> 1, 1, 2);
>         gtk_table_attach (tbl_auth, GTK_WIDGET (btn_dass), 1, 2, 1, 2,
> GTK_FILL, GTK_FILL, 0, 0);
>         gtk_box_pack_start (GTK_BOX (vbox_auth), GTK_WIDGET
> (tbl_auth), FALSE, FALSE, 0);
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches
>