[evolution-patches] [calendar] fix for bug#315329, 273322, 272290 (Evolution crashed on launching)



attached patch fixes bug#315329, 273322, 272290

e-pub-utils.c (e_pub_publish):
Set client as NULL, after g_object_unref (client)

the client was not set to NULL after g_object_unref, thats why all the
above three cases was failed in g_type_check_instance_is_a

Please review.

Regards,
Dinesh Layek

Index: e-pub-utils.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-pub-utils.c,v
retrieving revision 1.7
diff -u -p -r1.7 e-pub-utils.c
--- e-pub-utils.c	23 Feb 2005 18:56:56 -0000	1.7
+++ e-pub-utils.c	9 Sep 2005 12:24:52 -0000
@@ -264,6 +264,8 @@ e_pub_publish (gboolean publish) {
 				source =  e_source_list_peek_source_by_uid (source_list, source_uid);
 				if (source)
 					client = auth_new_cal_from_source (source, E_CAL_SOURCE_TYPE_EVENT);
+				else
+					continue;
 
 				if (!client) {
 					g_warning (G_STRLOC ": Could not publish Free/Busy: Calendar backend no longer exists");
@@ -288,6 +290,7 @@ e_pub_publish (gboolean publish) {
 				}
 				
 				g_object_unref (client);
+				client = NULL;
 			
 				g_free (source_uid);
 			}
Index: ../ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2803
diff -u -p -r1.2803 ChangeLog
--- ../ChangeLog	2 Sep 2005 13:58:02 -0000	1.2803
+++ ../ChangeLog	9 Sep 2005 12:24:55 -0000
@@ -1,3 +1,7 @@
+2005-09-09  Dinesh Layek  <ldinesh novell com>
+	Fixes bug# 315329, 273322, 272290
+	* e-pub-utils.c (e_pub_publish): Set client as NULL after g_object_unref
+
 2005-09-01  Dinesh Layek  <ldinesh novell com>
 
 	Fixes #314922, 311694, 314918


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]