[evolution-patches] patch to fix #240762(widgets/menus)



Hi Kaushal,

I have fixed #240762 earlier.
(<http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.29&r2=1.30>)

For I didn't deal with the non-built-in part, Srinivasa made a patch to
fix it.
(<http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.32&r2=1.33>)

But the latter patch reproduce the bug. Now I have a new patch to fix
this problem.
Please help me to review it. I know it's code freezing, it just for you
to review.

Thank you very much.

Best regards,
Li




? menus/gal-view-new-dialog.gladep
? table/e-table-config.gladep
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/ChangeLog,v
retrieving revision 1.139
diff -u -r1.139 ChangeLog
--- ChangeLog	4 Aug 2005 04:56:53 -0000	1.139
+++ ChangeLog	6 Sep 2005 12:05:31 -0000
@@ -1,3 +1,10 @@
+2005-09-06  Li Yuan  <li yuan sun com>
+
+	* menus/gal-define-views-dialog.c:
+	(etable_selection_change_forall_cb):
+	Fix #240762. If the galview implement the edit function, 
+	enable the edit button. If not, disable it.
+
 2005-08-03  Li Yuan  <li yuan sun com>
 
 	* menus/gal-view-new-dialog.glade:
Index: menus/gal-define-views-dialog.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/menus/gal-define-views-dialog.c,v
retrieving revision 1.33
diff -u -r1.33 gal-define-views-dialog.c
--- menus/gal-define-views-dialog.c	25 Jul 2005 04:30:33 -0000	1.33
+++ menus/gal-define-views-dialog.c	6 Sep 2005 12:05:31 -0000
@@ -218,10 +218,10 @@
 						  !item->built_in);
 			if (GAL_VIEW_GET_CLASS (item->view)->edit)
 				gtk_widget_set_sensitive (glade_xml_get_widget (dialog->gui, "button-modify"),
-						!item->built_in);
+						TRUE);
 			else
 				gtk_widget_set_sensitive (glade_xml_get_widget (dialog->gui, "button-modify"),
-						item->built_in);
+						FALSE);
 		}
 	}
 }






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]