Re: [evolution-patches] fix for #300217 (camel/providers/local)

[Not Zed <notzed ximian com>]

On Tue, 2005-09-06 at 15:05 +0530, Vivek Jain wrote:
> On Tue, 2005-09-06 at 16:59 +0800, Not Zed wrote:
> > Patch doesn't do what you say it will.
> I did not understand how? The earlier code was just checking for first
> character of the absolute new name, which would work only for the
> folders created at top level, I am checking for the new name given by
> user.

Well you said it will check for '.' in the parent too.  It doesn't, it
only checks for '.' in the first subfolder after the top folder, if
there is subfolders involved.

Using 'strrchr' will just check the last folder, which is all we care
about.

> > 
> > strstr?  sheesh, that's inefficient for looking for a char, you should
> > use strchr, infact you should use strrchr in this case, you want the
> > last one.
> Oh, wondering how/why I ended up using that, I will change it, thanks!.
> 
> > IMO, '.' names are perfectly valid anyway and there's no reason to hide
> > them.  The linux 'convention' is just a hack.
> Then looks like I should be working in another direction, I will see
> how/whether we can show hidden dirs in folder tree. Please drop some
> idea if you already have one.

It's probably just easier to stick with hiding '.', since thats what
we've always done.

-- 
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome