Re: [evolution-patches] fix for #310953 (camel-groupwise)
- From: Not Zed <notzed ximian com>
- To: Jain Vivek <jvivek novell com>
- Cc: evolution-patches gnome org
- Subject: Re: [evolution-patches] fix for #310953 (camel-groupwise)
- Date: Thu, 01 Sep 2005 21:46:17 +0800
Hmm I know this was already there, but these all leak the string they
pass to set_filename ...
camel_mime_part_set_filename(part, g_strdup(attach->name));
I don't know about the other logic surrounding that section, but it does
look strange. You can't set a multipart type to multipart/* without it
actually being the right type. e.g. multipart/encrypted must be a
CamelMultipartEncrypted, not just a plain CamelMultipart.
multipart/encrypted and multipart/signed specifically need to be treated
specially at a higher level anyway; because of some very impractical
requirements of one of the rfcs, although that isn't really critical.
But I guess if you can receive pgp/mime messages and they work, it
doesn't matter.
On Thu, 2005-09-01 at 03:27 -0600, Jain Vivek wrote:
> hi,
>
> The attached patch fixes
> http://bugzilla.gnome.org/show_bug.cgi?id=310953
>
> patch is attached on the bug.
>
> server doesn't return the contentType for some attachments, we have to
> check it and if there is no contentType we set it as multipart/digest.
>
> Thanks,
> Vivek Jain
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches
--
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]