Re: [evolution-patches] Exchange : fixes #312848

[Sarfraaz Ahmed <asarfraaz novell com>]

Thanks, modified accordingly and committed.

-- Sarfraaz

On Fri, 2005-10-21 at 16:48 +0530, shakti wrote:
> Hi Surf,
> 
> Isn't it good to use if...else if for checking the result status? like:
> 
> if (result == EXCHANGE_ACCOUNT_FOLDER_DOES_NOT_EXIST)
>         return GNOME_Evolution_Addressbook_NoSuchBook;
> else if (result == EXCHANGE_ACCOUNT_FOLDER_UNSUPPORTED_OPERATION)
>         return GNOME_Evolution_Addressbook_PermissionDenied;
> else if (result == EXCHANGE_ACCOUNT_FOLDER_OFFLINE)
>         return GNOME_Evolution_Addressbook_OfflineUnavailable;
> ...
> ...
> ...
> 
> Also, i feel it is good to check the status _OK first and then rest of
> the things with an else if.
> 
> Otherwise, patch looks good.
> 
> Thanks,
> Shakti
> 
> 
> 
> 
> On Fri, 2005-10-21 at 15:09 +0530, Sarfraaz Ahmed wrote:
> > Hi,
> > 
> > The first patch is for e-d-s, which properly checks that the folder
> > being deleted is a standard folder, and the other patch is for exchange,
> > which converts the error from the server to the proper backend value.
> > 
> > -- Sarfraaz
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-patches