Re: [evolution-patches] [MAIL]Patched for preview of mail

[Parthasarathi Susarla <sparthasarathi novell com>]

Looks good.

Thanks,
partha

On Fri, 2005-10-21 at 11:26 +0800, jeff.cai wrote:
> In function "em_folder_browser_show_preview" of file
> "em-folder-browser.c", you will find
> that the following code will not be effective:
> 
> if ((emfb->view.preview_active ^ state) == 0
>       || emfb->view.list == NULL)
>     return;
> 
> when the flag "preview_active" is TRUE, it is -1 in fact on linux as
> being declared one bit of int.
> So after XOR with state, the result will be -2, you can not get the
> expected result of returning
> directly.
> 
> cvs server: Diffing .
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
> retrieving revision 1.3720
> diff -u -p -r1.3720 ChangeLog
> --- ChangeLog   19 Oct 2005 11:32:05 -0000      1.3720
> +++ ChangeLog   21 Oct 2005 03:10:26 -0000
> @@ -1,3 +1,8 @@
> +2005-10-21  Jeff Cai <jeff cai sun com>
> +       * mail/em-folder-view.h : Change the declaration of flag
> 'preview_active'
> +        from one bit of int to one bit of guint because it will be -1
> on linux
> +       if being declared as one bit of int.
> +
>  2005-10-19  Philip Van Hoof <pvanhoof gnome org>
>         composer/e-msg-composer-select-file.c,
>         composer/e-msg-composer.c, composer/e-msg-composer.h,
> Index: em-folder-view.h
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/em-folder-view.h,v
> retrieving revision 1.16
> diff -u -p -r1.16 em-folder-view.h
> --- em-folder-view.h    16 May 2005 07:53:53 -0000      1.16
> +++ em-folder-view.h    21 Oct 2005 03:10:28 -0000
> @@ -91,7 +91,7 @@ struct _EMFolderView {
> 
>         int mark_seen_timeout;  /* local copy of gconf stuff */
>         int mark_seen:1;
> -       int preview_active:1;   /* is preview being used */
> +       guint preview_active:1; /* is preview being used */
>         int statusbar_active:1; /* should we manage the statusbar
> messages ourselves? */
>         int hide_deleted:1;
>         int list_active:1;      /* we actually showing the list? */
> 
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches