[evolution-patches] e_tasks_show_previews should not return a value (evolution/calendar/gui/e-tasks.c)
- From: Shiying Irene Huang <Irene Huang Sun COM>
- To: Evolution Patches <evolution-patches gnome org>
- Subject: [evolution-patches] e_tasks_show_previews should not return a value (evolution/calendar/gui/e-tasks.c)
- Date: Mon, 17 Oct 2005 16:11:20 +0800
Hi, Harish
When buidling evolution on Solaris, the process failed because the
void function e_tasks_show_previews returns a value via calling
g_return_val_if_fail.
I created a patch for this problem, please reviews.
Thank you very much.
-Irene
Index: ./calendar/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2827
diff -u -r1.2827 ChangeLog
--- ./calendar/ChangeLog 11 Oct 2005 09:07:23 -0000 1.2827
+++ ./calendar/ChangeLog 17 Oct 2005 07:53:43 -0000
@@ -1,3 +1,8 @@
+2005-10-17 Irene Huang <Irene Huang sun com>
+
+ * gui/e-tasks.c: (e_tasks_show_preview): Should not return a value, so,
+ change all the g_return_val_if_fail to g_return_if_fail.
+
2005-10-10 Chenthill Palanisamy <pchenthill novell com>
Fixes #266144, 317575.
Index: ./calendar/gui/e-tasks.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-tasks.c,v
retrieving revision 1.123
diff -u -r1.123 e-tasks.c
--- ./calendar/gui/e-tasks.c 6 Oct 2005 18:21:51 -0000 1.123
+++ ./calendar/gui/e-tasks.c 17 Oct 2005 07:53:43 -0000
@@ -1008,8 +1008,8 @@
{
ETasksPrivate *priv;
- g_return_val_if_fail (tasks != NULL, FALSE);
- g_return_val_if_fail (E_IS_TASKS (tasks), FALSE);
+ g_return_if_fail (tasks != NULL);
+ g_return_if_fail (E_IS_TASKS (tasks));
priv = tasks->priv;
if (state) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]