Re: [evolution-patches] Signature-editor : Patch for avoiding duplicate names

[Vivek Jain <jvivek novell com>]

hey sankar,

I see its a pretty good work done. Thanks for that.

Please correct your patch to fix:

1. "name" should be freed 
2. Check for the usage of "g_strstrip" 
3. Some styling issues here and there (a self review will make you
realize what you missed :))
4. The part of the error message "Change the name of your signature"
should probably be like "Please specify a different name"

Other than that the patch looks ok to me.

Thanks,
Vivek Jain

PS: Please do give a bit of detail about the work you have done in the
mail to patches.

On Mon, 2005-10-10 at 10:41 +0000, Sankar P  wrote:
> Fixed a few compilation warnings due to GObject type-casts
> and has attached an updated patch
> at :http://bugzilla.gnome.org/show_bug.cgi?id=269749
> 
> -- Sankar P
> 
> On Mon, 2005-10-10 at 15:11 +0530, Sankar P wrote:
> > Attached updated patch at :
> > http://bugzilla.gnome.org/show_bug.cgi?id=269749
> > Two new strings are added for empty-signatures and duplicate-signatures.
> > In addition to fixing the bug, it does,
> > 	-- Delete on Del key
> > 	-- Edit on Dbl.Click
> > 	-- Grabs focus to the tree, after something is deleted/edited.
> > 
> 
>