Re: [evolution-patches] Address book - ldif importer for mozilla attributes.

[Chris Toshok <toshok ximian com>]

He was pointing out that the "*i != '\0' && *i == ' '" part of that
expression is redundant (and confusing if left in).  Why not just use
"*i == ' '"?

Chris


On Fri, 2005-09-30 at 14:48 +0530, Sushma Rai wrote:
> That is to check a comma preceded by space, for formatting the 
> address entry.
> 
> I have committed the patch.
> 
> Thanks,
> Sushma.
> 
> On Wed, 2005-09-28 at 19:33 +0530, chen wrote:
> > On Tue, 2005-09-13 at 13:53 +0530, Sushma Rai wrote:
> > > +                       if (*c == ',' &&  *i != '\0' && *i == ' ') {
> > Is it intended to be like this  (*c == ',' && (*i != '\0' || *i == '
> > ') ?
> > 
> > Other than this the patch looks ok.
> > 
> > thanks, Chenthill.
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches