[evolution-patches] Re: fix for the crash



The bug id associated with it in bnc is 120071. Updated the ChangeLog
and committed the patch to gnome-2-12 and head. The acceptlevel should
be a const char* .

thanks, Chenthill.

On Tue, 2005-10-04 at 04:38 -0400, Dinesh Layek wrote:
> the attached patch fixes a crash.
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/calendar/ChangeLog,v
retrieving revision 1.510.2.8
diff -u -p -r1.510.2.8 ChangeLog
--- ChangeLog	1 Oct 2005 15:28:43 -0000	1.510.2.8
+++ ChangeLog	4 Oct 2005 08:47:54 -0000
@@ -1,3 +1,10 @@
+2005-10-04  Dinesh Layek  <ldinesh novell com>
+
+	Fixes #120071 
+	* backends/groupwise/e-cal-backend-groupwise-utils.c:
+	(e_gw_item_to_cal_component): Added a null check for
+	the acceptlevel.
+
 2005-10-01  Chenthill Palanisamy  <pchenthill novell com>
 
 	Fixes #314925
Index: backends/groupwise/e-cal-backend-groupwise-utils.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/calendar/backends/groupwise/e-cal-backend-groupwise-utils.c,v
retrieving revision 1.64.2.3
diff -u -p -r1.64.2.3 e-cal-backend-groupwise-utils.c
--- backends/groupwise/e-cal-backend-groupwise-utils.c	1 Oct 2005 15:28:44 -0000	1.64.2.3
+++ backends/groupwise/e-cal-backend-groupwise-utils.c	4 Oct 2005 08:47:55 -0000
@@ -1041,7 +1041,9 @@ e_gw_item_to_cal_component (EGwItem *ite
 			attendee->cutype = ICAL_CUTYPE_INDIVIDUAL;
 			 
 			if (recipient->status == E_GW_ITEM_STAT_ACCEPTED) {
-				if(!strcmp(e_gw_item_get_accept_level(item),"Tentative"))
+				const char *accept_level = e_gw_item_get_accept_level (item);
+
+				if(accept_level && !strcmp (e_gw_item_get_accept_level (item),"Tentative"))
 					attendee->status = ICAL_PARTSTAT_TENTATIVE;
 				else
 					attendee->status = ICAL_PARTSTAT_ACCEPTED;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]