[evolution-patches] [calendar] fix for bug #306673
- From: "Dinesh Layek" <ldinesh novell com>
- To: <evolution-patches gnome org>
- Subject: [evolution-patches] [calendar] fix for bug #306673
- Date: Mon, 03 Oct 2005 04:44:37 -0600
Attached patch fixes bug#306673 ("Save calendar" freezes evo after
missing file extension warning).
Please Review
Regards,
Dinesh
Index: save-calendar.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/save-calendar/save-calendar.c,v
retrieving revision 1.8
diff -u -p -r1.8 save-calendar.c
--- save-calendar.c 25 Feb 2005 09:55:29 -0000 1.8
+++ save-calendar.c 3 Oct 2005 10:37:22 -0000
@@ -185,7 +185,7 @@ ask_destination_and_save (EPlugin *ep, E
gtk_widget_show (extra_widget);
- if (gtk_dialog_run (GTK_DIALOG (dialog)) == GTK_RESPONSE_OK) {
+ while (gtk_dialog_run (GTK_DIALOG (dialog)) == GTK_RESPONSE_OK) {
char *tmp = NULL;
gtk_combo_box_get_active_iter (combo, &iter);
@@ -233,17 +233,16 @@ ask_destination_and_save (EPlugin *ep, E
/* Now we can destroy it */
gtk_widget_destroy (dialog);
g_free (dest_uri);
+ return;
}
-
- } else {
- /* Free the handlers */
- g_list_foreach (format_handlers, format_handlers_foreach_free, NULL);
- g_list_free (format_handlers);
-
- /* Now we can destroy it */
- gtk_widget_destroy (dialog);
- g_free (dest_uri);
}
+ /* Free the handlers */
+ g_list_foreach (format_handlers, format_handlers_foreach_free, NULL);
+ g_list_free (format_handlers);
+
+ /* Now we can destroy it */
+ gtk_widget_destroy (dialog);
+ g_free (dest_uri);
}
void
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/save-calendar/ChangeLog,v
retrieving revision 1.23
diff -u -p -r1.23 ChangeLog
--- ChangeLog 24 Aug 2005 03:13:50 -0000 1.23
+++ ChangeLog 3 Oct 2005 10:37:23 -0000
@@ -1,3 +1,9 @@
+2005-10-03 Dinesh Layek <ldinesh novell com>
+
+ Fixes #306673
+ * save-calendar.c (ask_destination_and_save): continue executing
+ gtk_dialog_run till it returns GTK_RESPONSE_OK and proceed is FALSE.
+
2005-08-23 Not Zed <NotZed Ximian com>
* ical-format.c: include missing header.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]