Re: [evolution-patches] fix for the bug #244981 [calendar]
- From: chen <pchenthill novell com>
- To: Harish Krishnaswamy <kharish novell com>
- Cc: patches <evolution-patches gnome org>
- Subject: Re: [evolution-patches] fix for the bug #244981 [calendar]
- Date: Sat, 01 Oct 2005 17:14:31 +0530
modified and committed to gnome-2-12 and head branches.
thanks, Chenthill.
On Sat, 2005-10-01 at 13:55 +0530, Harish Krishnaswamy wrote:
> On Fri, 2005-09-30 at 12:30 +0530, chen wrote:
>
> > + char buffer[32], buffer1 [32];
> >
> > date_tm.tm_year = 2001;
> > date_tm.tm_mon = 0;
> > @@ -1373,10 +1373,18 @@ print_week_day_event (GnomePrintContext
> >
> > e_time_format_time (&date_tm, psi->use_24_hour_format, FALSE,
> > buffer, sizeof (buffer));
> > +
> > + date_tm.tm_hour = event->end_minute / 60;
> > + date_tm.tm_min = event->end_minute % 60;
>
> You can perhaps reuse the buffer instead of defining additional memory
> on the stack. Could you make the change before committing.. The rest
> looks fine.
>
> Thanks,
> Harish
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]