Re: [evolution-patches] Fix the bug #322742

[Boby Wang <Boby Wang Sun COM>]

Patch revision for the Bug #322742.
On Tue, 2005-11-29 at 18:38 +0800, Boby Wang wrote:
> Hi,
>   I have attached the fix for the #322742 bug. The reproduction step
> follows:
> 1. Start evolution and screen reader
> 2. Focus on the mail list
> 3. Select a mail item
> 4. Move between subject and date by left and right arrows
> 
> Actual results:
> Screen Reader can't read the content of the subject or date.
> 
> Expected results:
> The item selected should be read.
>   There is something wrong in e-tree.c. I have modified the condition
> expression for GDK_RIGHT in the item_key_press function.
>   Enjoy it
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/table/ChangeLog,v
retrieving revision 1.6
diff -u -r1.6 ChangeLog
--- ChangeLog	25 Aug 2005 06:54:58 -0000	1.6
+++ ChangeLog	29 Nov 2005 10:48:17 -0000
@@ -1,3 +1,9 @@
+2005-11-29  Boby Wang  <boby wang sun com>
+
+	Fixes #322742.
+	* e-tree.c: (item_key_press):  change the condition
+	expression for GDK_RIGHT and GDK_LEFT.
+
 2005-08-24  Li Yuan  <li yuan sun com>
 
 	Fixes #314352.
Index: e-tree.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/table/e-tree.c,v
retrieving revision 1.115
diff -u -r1.115 e-tree.c
--- e-tree.c	15 Aug 2005 03:18:01 -0000	1.115
+++ e-tree.c	29 Nov 2005 10:48:17 -0000
@@ -886,7 +886,7 @@
 	case GDK_Right:
 	case GDK_KP_Right:
 		/* Only allow if the Shift modifier is used -- eg. Ctrl-Equal shouldn't be handled.  */
-		if (key->state & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK))
+		if ((key->state == 0) || (key->state & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK)))
 			break;
 		if (row != -1) {
 			path = e_tree_table_adapter_node_at_row(et->priv->etta, row);
@@ -899,7 +899,7 @@
 	case GDK_Left:
 	case GDK_KP_Left:
 		/* Only allow if the Shift modifier is used -- eg. Ctrl-Minus shouldn't be handled.  */
-		if (key->state & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK))
+		if ((key->state == 0) || (key->state & ~(GDK_SHIFT_MASK | GDK_LOCK_MASK)))
 			break;
 		if (row != -1) {
 			path = e_tree_table_adapter_node_at_row(et->priv->etta, row);