Re: [evolution-patches] Fix for the bug #321739 [calendar]



> madd = itip_strip_mailto (e_meeting_attendee_get_address (ma));
> +       
<snip>

> +       for (l = destinations; l; l = g_list_next (l)) {
> +                               if (madd && attendee && g_str_equal
> (madd, attendee)) {
> +
                                       g_object_unref (l->data);
<snip>

> +               } if (madd && attendee && g_str_equal (madd,
> attendee)) {
> +                       attendee = e_destination_get_email (des);
> +     

It is redundant (and a huge waste of cycles)  to check madd for NULL at
multiple places and inside a loop. Once should suffice.

Rest looks fine.


Thanks,
Harish




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]