Re: [evolution-patches] Addressbook: Groupwise backend, folder creation.



On Thu, 2005-11-17 at 11:19 +0530, Sushma Rai wrote:
> Hi,
> 
> This fix is to display message to user, to use some other
> groupwise mail client to get his frequent contacts, and 
> personal books created.

Patch looks good. 
Just a few things : 
- The error id can perhaps be more descriptive - like gw-book-init (or
something similar).
- Need some capitalization in the error message (GW System
Addressbook ?)- to be more consistent with the help documentation.
- The FIXME comment in the code can be removed now. 

Approved for HEAD.
Note : you need an approval from the i18n team for freeze break for
committing this to 2.4.x.

thanks, 
Harish





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]