Re: [evolution-patches] Fix for Bug 303856

[Srinivasa Ragavan <sragavan novell com>]

yeah chen, that will be nice. It is a different bug altogether and it
has to be fixed in event editor. So lets not mix with this bug. But this
is a global fix at misc/widgets.

-Srini
On Tue, 2005-11-22 at 14:42 +0530, chen wrote:
> I think it would be better if a check is made if the entered date value
> is valid after a focus change from the widget and set the old value if
> the entered one is invalid. The current behavior is, once u change the
> value in dateedit, the user has to press enter and dateedit would emit a
> changed signal, which enables the ok button, is not quite intuitive.
> 
> thanks, Chenthill.
> On Tue, 2005-11-22 at 13:28 +0530, Srinivasa Ragavan wrote:
> > Looks fine. But just a comment.
> > 
> > Make sure you attach the patch as a file too. its easy to apply try it
> > out and then commit.
> > 
> > -Srini.
> > On Tue, 2005-11-22 at 12:58 +0530, Johnny Jacob wrote:
> > > Hi
> > > worked on a patch for  bug 303856 - "Appointment Editor's OK button
> > > still greyed out
> > > after changing value. Please review this patch.
> > > 
> > > Johnny
> > > 
> > > 
> > > Index: widgets/misc/ChangeLog
> > > ===================================================================
> > > RCS file: /cvs/gnome/evolution/widgets/misc/ChangeLog,v
> > > retrieving revision 1.381
> > > diff -u -p -r1.381 ChangeLog
> > > --- widgets/misc/ChangeLog      17 Nov 2005 04:29:26 -0000      1.381
> > > +++ widgets/misc/ChangeLog      21 Nov 2005 23:51:48 -0000
> > > @@ -1,3 +1,9 @@
> > > +2005-11-22  Johnny Jacob  <johnnyjacob gmail com>
> > > +
> > > +       ** See Bug #303856
> > > +       * e-dateedit.c: (create_children) : Added a signal handler
> > > +       for date_entry's "key_release_event".
> > > +
> > >  2005-11-17  Harish Krishnaswamy  <kharish novell com>
> > > 
> > >         * e-attachment-bar.c: (update), (e_attachment_bar_set_width):
> > > Index: widgets/misc/e-dateedit.c
> > > ===================================================================
> > > RCS file: /cvs/gnome/evolution/widgets/misc/e-dateedit.c,v
> > > retrieving revision 1.47
> > > diff -u -p -r1.47 e-dateedit.c
> > > --- widgets/misc/e-dateedit.c   14 Nov 2005 14:45:42 -0000      1.47
> > > +++ widgets/misc/e-dateedit.c   21 Nov 2005 23:53:00 -0000
> > > @@ -147,6 +147,9 @@ static void e_date_edit_grab_focus          (Gtk
> > >  static gint on_date_entry_key_press            (GtkWidget      *widget,
> > >                                                  GdkEventKey    *event,
> > >                                                  EDateEdit      *dedit);
> > > +static gint on_date_entry_key_release          (GtkWidget      *widget,
> > > +                                                GdkEventKey    *event,
> > > +                                                EDateEdit      *dedit);
> > >  static void on_date_button_clicked             (GtkWidget      *widget,
> > >                                                  EDateEdit      *dedit);
> > >  static void e_date_edit_show_date_popup                (EDateEdit      *dedit);
> > > @@ -340,6 +343,9 @@ create_children                     (EDateEdit      *dedit)
> > >         g_signal_connect (priv->date_entry, "key_press_event",
> > >                           G_CALLBACK (on_date_entry_key_press),
> > >                           dedit);
> > > +       g_signal_connect (priv->date_entry, "key_release_event",
> > > +                         G_CALLBACK (on_date_entry_key_release),
> > > +                         dedit);
> > >         g_signal_connect_after (priv->date_entry,
> > >                                 "focus_out_event",
> > >                                 G_CALLBACK (on_date_entry_focus_out),
> > > @@ -1587,6 +1593,15 @@ on_time_entry_key_press                 
> > > (GtkWidget      *wi
> > >  }
> > > 
> > >  static gint
> > > +on_date_entry_key_release              (GtkWidget      *widget,
> > > +                                        GdkEventKey    *event,
> > > +                                        EDateEdit      *dedit)
> > > +{
> > > +       e_date_edit_check_date_changed (dedit);
> > > +       return TRUE;
> > > +}
> > > +
> > > +static gint
> > >  on_time_entry_key_release              (GtkWidget      *widget,
> > >                                          GdkEventKey    *event,
> > >                                          EDateEdit      *dedit)
> > > @@ -1597,7 +1612,7 @@ on_time_entry_key_release         (GtkWidget      *w
> > >                 e_date_edit_check_time_changed (dedit);
> > >                 return TRUE;
> > >         }
> > > -
> > > +       e_date_edit_check_time_changed (dedit);
> > >         return FALSE;
> > >  }
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches gnome org
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> > 
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-patches