Re: [evolution-patches] A crash for CamelDiscoStore



Approved by partha in irc, committed into both HEAD and gnome-2-12 branch with the style changes.
Thanks!
      Harry

Jeffrey Stedfast wrote:

please keep with the coding style of the rest of the evolution code

if (!store->diary)

Jeff

On Fri, 2005-11-18 at 11:34 +0800, jeff cai wrote:
Hi Here is the crash stack [1] __lwp_park(0x0, 0x0), at 0xd07c2749
 [2] mutex_lock_queue(0xcfd32400, 0x0, 0x8079f5c, 0x0), at 0xd07bb56c
 [3] slow_lock(0xcfd32400, 0x8079f5c, 0x0), at 0xd07bbe40
 [4] mutex_lock_impl(0x8079f5c, 0x0), at 0xd07bbf36
 [5] _mutex_lock(0x8079f5c), at 0xd07bc042
 [6] segv_redirect(0xb, 0x0, 0xcc65b9ac), at 0x8064029
 [7] __sighndlr(0xb, 0x0, 0xcc65b9ac, 0x8063fc3), at 0xd07c27ef
 ---- called from signal handler with signal 11 (SIGSEGV) ------
=>[8] camel_disco_diary_empty(0x0), at 0xce91fbb8
 [9] disco_connect(0x82ce678, 0x0), at 0xce921094
 [10] camel_service_connect(0x82ce678, 0x0), at 0xce9409d7
 [11] camel_imap_store_connected(0x82ce678, 0x0), at 0xcc6877b1
 [12] camel_imap_folder_fetch_data(0x96c4ac0, 0xbc5d4c8, 0xa3f1c28,
0x0, 0x0), at 0xcc67f035
 [13] write_to_stream(0x8c3ce70, 0x8a6cb08), at 0xcc68b528
 [14] camel_data_wrapper_write_to_stream(0x8c3ce70, 0x8a6cb08), at
0xcfc136ad
 [15] efh_text_plain(0x83e90e8, 0x8930c18, 0x862d850, 0xccef25b0), at
0xcce83e74
 [16] em_format_part_as(0x83e90e8, 0x8930c18, 0x862d850, 0xa99b540), at
0xcce87dae
 [17] emf_multipart_mixed(0x83e90e8, 0x8930c18, 0x89a77c8, 0xccef2748),
at 0xcce88cd0
 [18] em_format_part_as(0x83e90e8, 0x8930c18, 0x89a77c8, 0xaa9c830), at
0xcce87dae
 [19] em_format_part(0x83e90e8, 0x8930c18, 0x89a77c8), at 0xcce87e43
 [20] efh_format_message(0x83e90e8, 0x8930c18, 0x89a77c8, 0xccef2640),
at 0xcce861cc
 [21] efh_format_do(0x8c3db58), at 0xcce84c0e
 [22] mail_msg_received(0x81a5920, 0x8c3db58, 0x0), at 0xccea6087
 [23] thread_dispatch(0x81a5920), at 0xd03df700
 [24] _thr_setup(0xcfd32400), at 0xd07c22ea
[25] _lwp_start(), at 0xd07c26f0
We can see that parameter of function 'camel_disco_diary_empty' is null.
When camel disco diary is null, it indicates that no need to resync on
the disk files. I give a patch, pls review it.
_______________________________________________
Evolution-patches mailing list
Evolution-patches gnome org
http://mail.gnome.org/mailman/listinfo/evolution-patches

_______________________________________________
Evolution-patches mailing list
Evolution-patches gnome org
http://mail.gnome.org/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]