Re: [evolution-patches] Re: [Evolution-hackers] What does the cal-backend's CAL_STATIC_CAPABILITY_SAVE_SCHEDULES mean?



JP,
Yes, I didn't look at the code carefully. Attached is the updated patch. Please review it.
   Thanks!
      Harry

JP Rosevear wrote:

I don't think this will work because if you are publishing and the
backend does save_schedules you will bail out wrongly.

-JP
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2740
diff -u -r1.2740 ChangeLog
--- ChangeLog	24 May 2005 12:36:03 -0000	1.2740
+++ ChangeLog	26 May 2005 02:33:34 -0000
@@ -1,3 +1,8 @@
+2005-05-25  Harry Lu  <harry lu sun com>
+
+	* gui/itip-utils.c: (itip_send_comp): check whether backend could 
+	handle sending resuests/updates, and if so, just return.
+
 2005-05-24  Chenthill Palanisamy  <pchenthill novell com>
 
 	Fixes #272114
Index: gui/itip-utils.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/itip-utils.c,v
retrieving revision 1.98
diff -u -r1.98 itip-utils.c
--- gui/itip-utils.c	15 Mar 2005 16:05:07 -0000	1.98
+++ gui/itip-utils.c	26 May 2005 02:33:41 -0000
@@ -895,11 +895,15 @@
 	char *ical_string;
 	CORBA_Environment ev;
 	gboolean retval = FALSE;
+
+	/* check whether backend could handle sending resuests/updates */
+	if (method != E_CAL_COMPONENT_METHOD_PUBLISH && e_cal_get_save_schedules (client))
+		return TRUE;
 	
 	CORBA_exception_init (&ev);
 
 	/* Give the server a chance to manipulate the comp */
-	if (method != E_CAL_COMPONENT_METHOD_PUBLISH && !e_cal_get_save_schedules (client)) {
+	if (method != E_CAL_COMPONENT_METHOD_PUBLISH) {
 		if (!comp_server_send (method, send_comp, client, zones, &users))
 			goto cleanup;
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]