[evolution-patches] Leak fix in EBookListener



Hi,

The ->priv data was never freed when an EBookListener was destroyed, the
attached patch adds a dispose function to free it.

Ross
-- 
Ross Burton                                 mail: ross burtonini com
                                          jabber: ross burtonini com
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF

Index: addressbook/libebook/e-book-listener.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/libebook/e-book-listener.c,v
retrieving revision 1.16
diff -u -r1.16 e-book-listener.c
--- addressbook/libebook/e-book-listener.c	4 May 2005 08:46:12 -0000	1.16
+++ addressbook/libebook/e-book-listener.c	16 May 2005 13:43:04 -0000
@@ -437,6 +437,18 @@
 }
 
 static void
+e_book_listener_dispose (GObject *object)
+{
+	EBookListener *listener = E_BOOK_LISTENER (object);
+	if (listener->priv) {
+		g_free (listener->priv);
+		listener->priv = NULL;
+	}
+	if (G_OBJECT_CLASS (parent_class)->dispose)
+		G_OBJECT_CLASS (parent_class)->dispose (object);
+}
+
+static void
 e_book_listener_class_init (EBookListenerClass *klass)
 {
 	GObjectClass *object_class = G_OBJECT_CLASS (klass);
@@ -472,6 +484,8 @@
 	epv->notifyWritable             = impl_BookListener_report_writable;
 	epv->notifyConnectionStatus     = impl_BookListener_report_link_status;
 	epv->notifyAuthRequired         = impl_BookListener_report_auth_required;
+
+	object_class->dispose = e_book_listener_dispose;
 }
 
 BONOBO_TYPE_FUNC_FULL (

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]