Re: [evolution-patches] fix for 209416 - minicard-contactlist view -- Reworked
- From: Sushma Rai <rsushma novell com>
- To: Srinivasa Ragavan <sragavan novell com>
- Cc: evolution-patches lists ximian com
- Subject: Re: [evolution-patches] fix for 209416 - minicard-contactlist view -- Reworked
- Date: Wed, 11 May 2005 14:06:03 +0530
Looks ok for head.
Commit it with the changelog.
-Sushma.
On Mon, 2005-05-09 at 00:08 -0600, Srinivasa Ragavan wrote:
> Hope, i have fixed the formatting. Just removed the 4 tabspace in my vimrc.
>
> -Srini
>
> >>> Rodrigo Moya <rodrigo novell com> 05/06/05 1:57 PM >>>
> On Fri, 2005-05-06 at 01:53 -0600, Srinivasa Ragavan wrote:
> > Please review this patch and give me the comments.
> > If fine, i can commit it.
> >
> just a little comment even though addressbook is not my area:
> > + gnome_canvas_item_set( new_item,
> > + "width", e_minicard->width -
> > 4.0,
> > + "fieldname", string,
> > + "field", "",
> > + "max_field_name_length",
> > left_width,
> > + "editable", FALSE /*
> > e_minicard->editable */,
> > + NULL );
> > + else
> > + gnome_canvas_item_set( new_item,
> > + "width", e_minicard->width -
> > 4.0,
> > + "fieldname", name,
> > + "field", string,
> > + "max_field_name_length",
> > left_width,
> > + "editable", FALSE /*
> > e_minicard->editable */,
> > + NULL );
> >
> formatting seems to be totally broken here.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]