Re: [evolution-patches] Patch for memory leaks : Groupwise backend, calendar and address book

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2005-05-05 at 12:42 +0530, Sushma Rai wrote:
> 
> plain text document attachment (eds-memleaks.diff)
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-server/ChangeLog,v
> retrieving revision 1.254
> diff -u -p -r1.254 ChangeLog
> --- ChangeLog	4 May 2005 12:59:27 -0000	1.254
> +++ ChangeLog	5 May 2005 06:49:24 -0000
> @@ -1,3 +1,13 @@
> +2005-05-04  Sushma Rai <rsushma novell com>
> +
> +	* servers/groupwise/e-gw-item.c 
> +	(set_contact_fields_from_soap_parameter): Freeing value, 
> +	postal_address.
> +	(e_gw_item_new_from_soap_parameter): Freeing "to", priority.
> +
> +	* servers/groupwise/e-gw-connection.c
> +	(e_gw_connection_get_quick_messages): Checking for NULL start date.
> +
servers/groupwise has its own ChangeLog, so this should be added to that
one, not to the top level one.

>  2005-05-04  Rodrigo Moya <rodrigo novell com>
> @@ -1023,6 +1023,8 @@ set_contact_fields_from_soap_parameter (
>  			value = soup_soap_parameter_get_string_value (temp);
>  			if (value && (!primary_email ||  !g_str_equal (primary_email, value)))
>  				item->priv->email_list = g_list_append (item->priv->email_list, value);
> +			else
> +				g_free (value);
>  		}
hmm, AFAICS, the g_free should be in the if statement block, or out of
both if/else.

the calendar part looks ok though, so that can be committed.
-- 
Rodrigo Moya <rodrigo novell com>