[evolution-patches] Patch for #74055



Dear rodo,

Here is the patch for #74055
the related URL is:
http://bugzilla.ximian.com/show_bug.cgi?id=74055

In fact, I had sent it to you on Mar 26th.

Will you please help me to review it?

In addition, rodo, I doubt that there is something wrong with the iframe
gtkhtml widget.

1), In this case. the  iframe's engine->y_offset is always zero. I remember
you'v told me that the y_offset is the offset of the view. But why it is
always zero here. Is it because the iframe widget has no scollbar ??

2), In the same case, the iframe's engine->height is always a constant
while the top gtkhtml widget's engine->height is a variable which depends
on the height of view.

What is your opinion? Thanks:)


Yours,
Mengjie
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
retrieving revision 1.2110
diff -u -p -r1.2110 ChangeLog
--- ChangeLog	23 Mar 2005 21:21:50 -0000	1.2110
+++ ChangeLog	24 Mar 2005 10:28:14 -0000
@@ -1,3 +1,10 @@
+2005-03-26  Yu Mengjie  <meng-jie yu sun com>
+
+	* gtkhtml.c: (idle_handler):
+	check whether we have iframe_parent.
+
+	Fixes #74055
+
 2005-03-23  Radek Doulik  <rodo novell com>
 
 	* htmlgdkpainter.c (draw_glyphs): maintain fg color unchanged
Index: gtkhtml.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/gtkhtml.c,v
retrieving revision 1.594
diff -u -p -r1.594 gtkhtml.c
--- gtkhtml.c	10 Mar 2005 12:24:04 -0000	1.594
+++ gtkhtml.c	24 Mar 2005 10:29:00 -0000
@@ -376,6 +376,10 @@ idle_handler (gpointer data)
 	gtk_html_private_calc_scrollbars (html, NULL, NULL);
 	
  	html->priv->idle_handler_id = 0;
+
+	if (html->iframe_parent)
+		idle_handler (html->iframe_parent);
+
 	return FALSE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]