Re: [evolution-patches] Exchange favourite folders

[Harish Krishnaswamy <kharish novell com>]

On Tue, 2005-03-29 at 03:28 -0700, Ahmed Sarfraaz wrote:
> This patch handles the favourite folder handling in a more cleaner way
> and also fixes the ref count on the folders going wrong. Changelog has
> the explainations.
> 
> Thanks
> -- Sarfraaz


>                                      folder);
> -               table_updated = 1;
>         }
> +
> +       g_object_ref (folder);
> +
>         if (permanent_uri && (!g_hash_table_lookup
> (account->priv->folders, 
there is an additional ref here, unattached to any insert operation.

In some places in the function, the entries are unref'd twice - i cant
understand exactly why  - perhaps you can add a comment or two to
explain the same.

Have you considered using the g_hash_table_new_full to initialize
account->priv->folders, so it can simplify the ref/unref logic used in
all the above functions..

Thanks,
harish