Re: [evolution-patches] fix for bug #73885

[Not Zed <notzed ximian com>]

Hmm, we don't do a blind translation of folder names anywhere else, why should you do it here?

This is wrong on so many levels.

You need to get the translated name from the selection (which is available, if not to it, in the folderinfo it gets it from), you can't just translate the raw name.

On Wed, 2005-03-23 at 20:07 +0000, Jeffrey Stedfast wrote:

text/plain attachment (73885.patch)

? 33933.patch
? 55303-2.patch
? 55303.patch
? 59717.patch
? 62109.patch
? 62377.patch
? 62665.patch
? 62771-mailer.patch
? 62812.patch
? 63177.patch
? 64974.patch
? 65448.patch
? 70394.patch
? 73885.patch
? default/zh_CN/Makefile
? default/zh_CN/Makefile.in
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3610
diff -u -r1.3610 ChangeLog
--- ChangeLog	17 Mar 2005 19:00:00 -0000	1.3610
+++ ChangeLog	23 Mar 2005 20:09:48 -0000
@@ -1,3 +1,8 @@
+2005-03-23  Jeffrey Stedfast  <fejj novell com>
+
+	* em-account-editor.c (emae_account_folder_changed): Translate the
+	folder name here, fixes bug #73885.
+
 2005-03-16  Jeffrey Stedfast  <fejj novell com>
 
 	* em-format-html.c (efh_format_headers): Don't show multiple
Index: em-account-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-account-editor.c,v
retrieving revision 1.24
diff -u -r1.24 em-account-editor.c
--- em-account-editor.c	2 Mar 2005 05:23:45 -0000	1.24
+++ em-account-editor.c	23 Mar 2005 20:09:48 -0000
@@ -811,7 +811,7 @@
 {
 	int item = GPOINTER_TO_INT(g_object_get_data((GObject *)folder, "account-item"));
 
-	e_account_set_string(emae->account, item, em_folder_selection_button_get_selection(folder));
+	e_account_set_string(emae->account, item, _(em_folder_selection_button_get_selection(folder)));
 }
 
 static EMFolderSelectionButton *