[evolution-patches] Re: Exchange connector: Patch for 74050

["Ahmed Sarfraaz" <asarfraaz novell com>]

Looks fine, except for one minor change below.


text/plain attachment (74050.diif)
> Index: lib/e2k-autoconfig.c
> ===================================================================
> 
 				 E2K_AUTOCONFIG_USE_EITHER);
> @@ -1409,22 +1410,44 @@ validate (const char *owa_url, char *use
>  	result = e2k_autoconfig_check_exchange (ac, &op);
> 
 		euri = e2k_uri_new (ac->home_uri);
> -		exchange_params->owa_path = g_strdup (euri->path + 1);
> +		path = g_strdup (euri->path + 1);
>  		e2k_uri_free (euri);
> 

You can as well dup the whole euri->path string and later on mask it as
"path +1" below, and thus avoid that printf later on. That would make
things more clear. Its just a matter of choice and a minor thing anyway.

> +		mailbox = strrchr (path, '/');
> +		if (mailbox && !mailbox[1]) {
> +			*mailbox = '\0';
> +			mailbox = strrchr (path, '/');
>  		}

> +		exchange_params->mailbox  = g_strdup (mailbox);
> +		exchange_params->owa_path = g_strdup_printf ("%s%s",
"/", path);
> +		g_free (path);
> 

-- Sarfraaz