Re: [evolution-patches] Exchange connector - authentication mechanisms

["Ahmed Sarfraaz" <asarfraaz novell com>]

This looks fine, except for one change mentioned below.

 
> Index: camel/camel-exchange-provider.c
> ===================================================================
> RCS file:
/cvs/gnome/evolution-exchange/camel/camel-exchange-provider.c,v
> retrieving revision 1.17
> diff -u -p -r1.17 camel-exchange-provider.c
> --- camel/camel-exchange-provider.c     15 Mar 2005 09:40:13 -0000    
 1.17
> +++ camel/camel-exchange-provider.c     16 Mar 2005 12:36:36 -0000
> @@ -151,11 +151,15 @@ exchange_validate_user_cb (CamelURL *cam
>         exchange_params->ad_server = NULL;
>         exchange_params->mailbox = NULL;
>         exchange_params->owa_path = NULL;
> +       exchange_params->is_ntlm = TRUE;
>  
>         valid = e2k_validate_user (owa_url, camel_url->user, 
>                                    exchange_params,
remember_password);
>  
> +       /* If not valid we will not proceed with account setup */
>         camel_url_set_host(camel_url, valid?exchange_params->host:"");
> +       if (valid)
> +               camel_url_set_authmech (camel_url,
exchange_params->is_ntlm?"NTLM":"Basic");
>         camel_url_set_param(camel_url, "ad_server",
valid?exchange_params->ad_server:NULL);
> 
As we talked on IRC, may be we can have a single check for valid for all
params and set them only if valid is true, as they are anyway not used
in the plugin when valid is false.

Thanks
-- Sarfraaz