[evolution-patches] 73363, message list selection timeout

[Not Zed <notzed ximian com>]

bug report explains it well



Index: mail/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3604
diff -u -p -r1.3604 ChangeLog
--- mail/ChangeLog	11 Mar 2005 01:27:27 -0000	1.3604
+++ mail/ChangeLog	16 Mar 2005 05:45:17 -0000
@@ -1,3 +1,13 @@
+2005-03-16  Not Zed  <NotZed Ximian com>
+
+	** See bug #73363
+
+	* em-folder-view.c (emfv_list_message_selected): insert a timeout
+	before loading the message.
+	(emfv_message_selected_timeout): handle the timeout, start loading
+	the message.
+	(emfv_set_folder, emfv_destroy): cleanups for above.
+
 2005-03-10  Not Zed  <NotZed Ximian com>
 
 	** See bug #73293
Index: mail/em-folder-view.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-folder-view.c,v
retrieving revision 1.110
diff -u -p -r1.110 em-folder-view.c
--- mail/em-folder-view.c	23 Feb 2005 06:08:47 -0000	1.110
+++ mail/em-folder-view.c	16 Mar 2005 05:45:18 -0000
@@ -132,6 +132,7 @@ static const EMFolderViewEnable emfv_ena
 struct _EMFolderViewPrivate {
 	guint seen_id;
 	guint setting_notify_id;
+	guint selected_id;
 	int nomarkseen:1;
 	int destroyed:1;
 
@@ -140,6 +141,8 @@ struct _EMFolderViewPrivate {
 
 	GalViewInstance *view_instance;
 	GalViewMenus *view_menus;
+
+	char *selected_uid;
 };
 
 static GtkVBoxClass *emfv_parent;
@@ -255,6 +258,14 @@ emfv_destroy (GtkObject *o)
 		p->invisible = NULL;
 	}
 
+	if (p->selected_id != 0) {
+		g_source_remove(p->selected_id);
+		p->selected_id = 0;
+	}
+
+	g_free(p->selected_uid);
+	p->selected_uid = NULL;
+
 	emfv->preview = NULL;
 	emfv->list = NULL;
 	emfv->preview_active = FALSE;
@@ -556,6 +567,9 @@ emfv_set_folder(EMFolderView *emfv, Came
 	
 	if (folder == emfv->folder)
 		return;
+
+	if (emfv->priv->selected_id)
+		g_source_remove(emfv->priv->selected_id);
 	
 	if (emfv->preview)
 		em_format_format ((EMFormat *) emfv->preview, NULL, NULL, NULL);
@@ -2137,24 +2151,46 @@ emfv_list_done_message_selected(CamelFol
 	g_object_unref (emfv);
 }
 
+static gboolean
+emfv_message_selected_timeout(void *data)
+{
+	EMFolderView *emfv = data;
+
+	if (emfv->priv->selected_uid) {
+		if (emfv->displayed_uid == NULL || strcmp(emfv->displayed_uid, emfv->priv->selected_uid) != 0) {
+			g_free(emfv->displayed_uid);
+			emfv->displayed_uid = emfv->priv->selected_uid;
+			emfv->priv->selected_uid = NULL;
+			g_object_ref (emfv);
+			/* TODO: we should manage our own thread stuff, would make cancelling outstanding stuff easier */
+			mail_get_message(emfv->folder, emfv->displayed_uid, emfv_list_done_message_selected, emfv, mail_thread_queued);
+		} else {
+			g_free(emfv->priv->selected_uid);
+			emfv->priv->selected_uid = NULL;
+		}
+	} else {
+		g_free(emfv->displayed_uid);
+		emfv->displayed_uid = NULL;
+		em_format_format((EMFormat *)emfv->preview, NULL, NULL, NULL);
+		emfv->priv->nomarkseen = FALSE;
+	}
+
+	emfv->priv->selected_id = 0;
+
+	return FALSE;
+}
+
 static void
 emfv_list_message_selected(MessageList *ml, const char *uid, EMFolderView *emfv)
 {
 	if (emfv->preview_active) {
-		if (uid) {
-			if (emfv->displayed_uid == NULL || strcmp(emfv->displayed_uid, uid) != 0) {
-				g_free(emfv->displayed_uid);
-				emfv->displayed_uid = g_strdup(uid);
-				g_object_ref (emfv);
-				/* TODO: we should manage our own thread stuff, would make cancelling outstanding stuff easier */
-				mail_get_message(emfv->folder, uid, emfv_list_done_message_selected, emfv, mail_thread_queued);
-			}
-		} else {
-			g_free(emfv->displayed_uid);
-			emfv->displayed_uid = NULL;
-			em_format_format((EMFormat *)emfv->preview, NULL, NULL, NULL);
-			emfv->priv->nomarkseen = FALSE;
-		}
+		if (emfv->priv->selected_id != 0)
+			g_source_remove(emfv->priv->selected_id);
+
+		emfv->priv->selected_id = g_timeout_add(100, emfv_message_selected_timeout, emfv);
+
+		g_free(emfv->priv->selected_uid);
+		emfv->priv->selected_uid = g_strdup(uid);
 	}
 
 	emfv_enable_menus(emfv);