[evolution-patches] patch for exchange connector



Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-exchange/ChangeLog,v
retrieving revision 1.296
diff -u -p -r1.296 ChangeLog
--- ChangeLog	11 Mar 2005 14:58:26 -0000	1.296
+++ ChangeLog	14 Mar 2005 09:29:33 -0000
@@ -1,3 +1,16 @@
+2005-03-14  Sivaiah Nallagatla <snallagatla novell com>
+
+	* addresbook/e-book-backend-excahnge.c 
+	(e_book_backend_exchange_create_contact) 
+	(e_book_backend_exchange_modify_contact)
+	(e_book_backend_exchange_remove_contacts)
+	(e_book_backend_exchange_get_changes)
+	(e_book_backend_exchange_get_contact) : added misc. stuff
+	like returning proper error code, assigning 
+	NULL to out params and not using e_data_book_view etc
+	to offline case error handling
+	Don't know if it fixes any bug in bugzilla
+
 2005-03-11  Sushma Rai  <rsushma novell com>
 
 	* addressbook/e-book-backend-exchange.c (func_match): Handling the
Index: addressbook/e-book-backend-exchange.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/addressbook/e-book-backend-exchange.c,v
retrieving revision 1.24
diff -u -p -r1.24 e-book-backend-exchange.c
--- addressbook/e-book-backend-exchange.c	11 Mar 2005 14:58:27 -0000	1.24
+++ addressbook/e-book-backend-exchange.c	14 Mar 2005 09:29:35 -0000
@@ -1274,6 +1274,7 @@ e_book_backend_exchange_create_contact (
 	switch (bepriv->mode) {
 
 	case GNOME_Evolution_Addressbook_MODE_LOCAL:
+		*contact = NULL;
 		return GNOME_Evolution_Addressbook_RepositoryOffline;
 	
 	case GNOME_Evolution_Addressbook_MODE_REMOTE:	
@@ -1345,6 +1346,8 @@ e_book_backend_exchange_modify_contact (
 	switch (bepriv->mode) {
 	
 	case GNOME_Evolution_Addressbook_MODE_LOCAL:
+		*contact = NULL;
+		return GNOME_Evolution_Addressbook_RepositoryOffline;
 
 	case GNOME_Evolution_Addressbook_MODE_REMOTE:
 
@@ -1451,13 +1454,9 @@ e_book_backend_exchange_remove_contacts 
 	switch (bepriv->mode) {
 
 	case GNOME_Evolution_Addressbook_MODE_LOCAL:
-		e_data_book_respond_remove_contacts (book, 
-						     opid, 
-						     GNOME_Evolution_Addressbook_RepositoryOffline, 
-						     NULL);
-		return GNOME_Evolution_Addressbook_Success; 
-		// GNOME_Evolution_Addressbook_RepositoryOffline FIXME
-	
+		*removed_ids = NULL;
+		return GNOME_Evolution_Addressbook_RepositoryOffline; 
+		
 	case GNOME_Evolution_Addressbook_MODE_REMOTE:
 
 		for (l = id_list; l; l = l->next) {
@@ -1954,8 +1953,8 @@ e_book_backend_exchange_get_changes (EBo
 	switch (bepriv->mode) {
 	
 	case GNOME_Evolution_Addressbook_MODE_LOCAL:
-		/* FIXME */
-		return GNOME_Evolution_Addressbook_Success;
+		*changes = NULL;
+		return GNOME_Evolution_Addressbook_RepositoryOffline;
 
 	case GNOME_Evolution_Addressbook_MODE_REMOTE:
 
@@ -2049,22 +2048,16 @@ e_book_backend_exchange_get_contact (EBo
 	case GNOME_Evolution_Addressbook_MODE_LOCAL:
 		contact = e_book_backend_cache_get_contact (bepriv->cache,
 							    id);
-		*vcard =  e_vcard_to_string (E_VCARD (contact), 
-					    EVC_FORMAT_VCARD_30);
 		if (contact) {
-			e_data_book_respond_get_contact(book, 
-							opid, 
-							GNOME_Evolution_Addressbook_Success, 
-							*vcard);
+			*vcard =  e_vcard_to_string (E_VCARD (contact), 
+						     EVC_FORMAT_VCARD_30);
 			g_object_unref (contact);
+			return GNOME_Evolution_Addressbook_Success;
 		}
 		else {
-			e_data_book_respond_get_contact(book, 
-							opid, 
-							GNOME_Evolution_Addressbook_ContactNotFound, 
-							"");
+			*vcard = g_strdup ("");
+			return GNOME_Evolution_Addressbook_ContactNotFound;
 		}
-		return GNOME_Evolution_Addressbook_Success; //FIXME
 		
 	case GNOME_Evolution_Addressbook_MODE_REMOTE:
 		/* XXX finish this */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]