new patch attached
On Fri, 2005-03-11 at 09:13 +0800, Not Zed wrote:
>
> Should it check if permanentflags is empty?
>
> On Thu, 2005-03-10 at 14:50 -0500, Jeffrey Stedfast wrote:
> > If the client is not permitted to modify the mailbox but is
> > permitted read access, the mailbox is selected as read-only,
> > and
> > the server MUST prefix the text of the tagged OK response to
> > SELECT with the "[READ-ONLY]" response code. Read-only access
> > through SELECT differs from the EXAMINE command in that
> > certain
> > read-only mailboxes MAY permit the change of permanent state
> > on a
> > per-user (as opposed to global) basis. Netnews messages
> > marked in
> > a server-based .newsrc file are an example of such per-user
> > permanent state that can be modified with read-only mailboxes.
> >
> > I've mailed Mark Crispin on the subject for clarification (which
> > I'll post when I receive a reply), but it sounds like our
> > implementation is wrong after re-reading the above paragraph.
> >
> > Jeff
> >
> > --
> > Jeffrey Stedfast
> > Evolution Hacker - Novell, Inc.
> > fejj ximian com - www.novell.com
> > text/plain attachment (70425.patch)
> > ? 70425.patch
> > Index: ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/ChangeLog,v
> > retrieving revision 1.10
> > diff -u -r1.10 ChangeLog
> > --- ChangeLog 23 Feb 2005 06:17:15 -0000 1.10
> > +++ ChangeLog 10 Mar 2005 19:45:30 -0000
> > @@ -1,3 +1,9 @@
> > +2005-03-10 Jeffrey Stedfast <fejj novell com>
> > +
> > + * camel-imap-folder.c (imap_sync_online): READ-ONLY doesn't mean
> > + we can't sync flags, allow flag syncing even in READ-ONLY mode
> > + (spec says we can if PERMANENTFLAGS is non-empty).
> > +
> > 2005-02-22 Not Zed <NotZed Ximian com>
> >
> > ** See bug #61468
> > Index: camel-imap-folder.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/camel-imap-folder.c,v
> > retrieving revision 1.346
> > diff -u -r1.346 camel-imap-folder.c
> > --- camel-imap-folder.c 23 Feb 2005 06:17:15 -0000 1.346
> > +++ camel-imap-folder.c 10 Mar 2005 19:45:31 -0000
> > @@ -765,11 +765,6 @@
> > gboolean unset;
> > int i, j, max;
> >
> > - if (((CamelImapFolder *)folder)->read_only) {
> > - imap_sync_offline (folder, ex);
> > - return;
> > - }
> > -
> > camel_exception_init (&local_ex);
> > CAMEL_SERVICE_LOCK (store, connect_lock);
> >
--
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com - www.novell.com
? 70425.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/ChangeLog,v
retrieving revision 1.10
diff -u -r1.10 ChangeLog
--- ChangeLog 23 Feb 2005 06:17:15 -0000 1.10
+++ ChangeLog 11 Mar 2005 18:28:33 -0000
@@ -1,3 +1,10 @@
+2005-03-10 Jeffrey Stedfast <fejj novell com>
+
+ * camel-imap-folder.c (imap_sync_online): READ-ONLY doesn't mean
+ we can't sync flags, allow flag syncing even in READ-ONLY mode
+ since the RFC states that flags listed in PERMANENTFLAGS are
+ always settable.
+
2005-02-22 Not Zed <NotZed Ximian com>
** See bug #61468
Index: camel-imap-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/camel-imap-folder.c,v
retrieving revision 1.346
diff -u -r1.346 camel-imap-folder.c
--- camel-imap-folder.c 23 Feb 2005 06:17:15 -0000 1.346
+++ camel-imap-folder.c 11 Mar 2005 18:28:34 -0000
@@ -765,11 +765,11 @@
gboolean unset;
int i, j, max;
- if (((CamelImapFolder *)folder)->read_only) {
+ if (folder->permanent_flags == 0) {
imap_sync_offline (folder, ex);
return;
}
-
+
camel_exception_init (&local_ex);
CAMEL_SERVICE_LOCK (store, connect_lock);
Attachment:
smime.p7s
Description: S/MIME cryptographic signature