Re: [evolution-patches] connector fix for bug #72889 and others

[Sarfraaz Ahmed <asarfraaz novell com>]

Ok, as we talked on irc yesterday, i applied your patch again and i didnt get that error about "Could not connect to backend process". I am not sure what was wrong in my setup when i tested it earlier. I guess we can discard my patch.

Your patch looks fine to me. Please commit it.

Thanks
-- Sarfraaz

On Wed, 2005-03-09 at 11:48 -0500, Jeffrey Stedfast wrote:
> On Wed, 2005-03-09 at 12:37 +0530, Sarfraaz Ahmed wrote:
> > On Tue, 2005-03-08 at 10:31 -0500, Jeffrey Stedfast wrote: 
> > > what happens if you start in offline mode?
> > > 
> > The connect gets called from camel-exchange when a get_folder_info is
> > invoked ... so then the stub between camel and connector gets
> > initialized and the connector sends the folder info it fetches from
> > the offline folder data on the stub.
>
> actually, there's 3 places that camel_service_connect() gets called in
> the camel-exchange-store.c code - get_folder(), get_folder_info() and
> something else. I forget.
>
> anyways, wouldn't it be cleaner to simply connect to the exchange
> storage daemon in construct() anyway? why try to connect in 3 different
> places when we can connect in a single place?
>
> I can update the patch remove the RETURN_IF_NOT_CONNECTED() macro calls
> in get_folder(), get_folder_info() and the other one if we agree.
>
> Jeff