Re: [evolution-patches] patch for #72044 (exchange connector)

[Sivaiah Nallagatla <snallagatla novell com>]

What is there in the patch exactly does the same thing you wanted and
without even a goto. Avoided the else case by initializing text_part to
NULL and commiteed.

Siva

On Wed, 2005-03-09 at 17:03 +0530, Sushma Rai wrote:
> Patch looks fine.
> 
> But checks for note and photo being NULL looks little
> confusing for me.
> 
> Can it be reorganized something like this?
> 
> 
> text_part = NULL;
> 
> if (!note && !photo) {
> 	goto write_to_stream;
> }
> else if (note && photo)
> 	text_part = camel_mime_part_new ();
> else if (note) {        
> 	/* only note */
>     	text_part = CAMEL_MIME_PART (msg);
> }
> 
> if (text_part) {
>     	/* either both note and photo exist or only the note exists */
>     
>     	camel_medium_set_content_object (CAMEL_MEDIUM (text_part), 
> 					 wrapper);
>     	camel_mime_part_set_encoding (text_part,
> 					CAMEL_TRANSFER_ENCODING_8BIT);
> }
> 
> 
> -Sushma.
> 
> 
> On Wed, 2005-03-09 at 09:10 -0800, Sivaiah Nallagatla wrote:
> > This happens when one imports a contact with photo but no note. 
> > 
> > Siva
>