[evolution-patches] Re: Exchange connector: patch for #72389

[Sarfraaz Ahmed <asarfraaz novell com>]

Some comments below ...

On Tue, 2005-03-08 at 15:15 +0530, Sushma Rai wrote:
>     Hi,
>     
>     This patch fixes the problem of displaying quota warnings always,
>     whenever some quota limits are set for the user, even if he is
>     not exceeding the quota.
>     
>     Please review,
>     -Sushma.
>     
>     -               entry->mask |= E2K_GLOBAL_CATALOG_LOOKUP_QUOTA;
>     -               ldap_value_free (values);       
>     +       if (!strcmp (quota_setting_values[0], "TRUE")) {
>     +               /* use global mailbox store settings */
>     +               E2K_GC_DEBUG_MSG(("GC: Using global mailbox store limits\n"));
Please add a TODO: note here.
>     +       }
>     +       ldap_value_free (quota_setting_values);

>     Index: storage/exchange-account.c
>     ===================================================================
>     RCS file: /cvs/gnome/evolution-exchange/storage/exchange-account.c,v
>     retrieving revision 1.37
>     diff -u -p -r1.37 exchange-account.c
>     --- storage/exchange-account.c  7 Mar 2005 05:35:05 -0000       1.37
>     +++ storage/exchange-account.c  8 Mar 2005 09:30:55 -0000
>     @@ -1237,11 +1237,15 @@ setup_account_hierarchies (ExchangeAccou
>                     return FALSE;
>             }
>      
>     +       account->mbox_size = exchange_hierarchy_webdav_get_total_folder_size (
>     +                                       EXCHANGE_HIERARCHY_WEBDAV (personal_hier));
>     +
Guess you forgot to send the code for hierarchy-webdav.c ?
>     -