[evolution-patches] Re: Request for code freeze break

[Luis Villa <luis villa gmail com>]

2/2, assuming the evo-patches list has already done actual code review.
Luis


On Fri, 04 Mar 2005 17:30:44 +0100, Murray Cumming <murrayc murrayc com> wrote:
> On Fri, 2005-03-04 at 21:56 +0530, Sivaiah Nallagatla wrote:
> > This is a resend with subject changed to get noticed :)
> >
> > Hi,
> > This is a request to break code freeze for evolution module to fix
> > http://bugzilla.ximian.com/show_bug.cgi?id=73152
> >
> > Whenever user changes any properties of Personal calendar or address
> > books , a duplicate Personal calendar or address book gets created on
> > next invocation of evolution. This can be very annoying and user may get
> > confused between one he was using and the one newly got created.
> 
> This sounds awful. 1 of 2 approvals.
> 
> > The code is change is very minimal. Bascailly addressbook-file and
> > calednar-file plugins were setting the relative uris unconditionally and
> > hence changing the relative uris of Personal calendar and adress book
> > which should not happen. A check has been added to set relative uri only
> > when it did not exist earlier. This has been tested and approved by
> > evolution maitainers.
> >
> > Siva
> >
> > On Wed, 2005-03-02 at 18:14 +0100, Rodrigo Moya wrote:
> > > On Wed, 2005-03-02 at 13:20 +0100, Rodrigo Moya wrote:
> > > > On Wed, 2005-03-02 at 17:41 -0800, Sivaiah Nallagatla wrote:
> > > > > email message attachment, "Forwarded message - [evolution-patches]
> > > > > patch for #73512 (calendar file and adress book file plugins)"
> > > > > On Wed, 2005-03-02 at 17:41 -0800, Sivaiah Nallagatla wrote:
> > > > > > Both calendar-file and addressbook-file are cahnging the uri's of the
> > > > > > system calendar and books to sources uid from "system" when their
> > > > > > proprties are edited. So ensure_sources creates them again as it did not
> > > > > > system calendat and book.
> > > > > >
> > > > calendar part looks ok to me
> > >
> > > not that I can approve it, but addressbook part looks ok to me also
> > _______________________________________________
> > release-team mailing list
> > release-team gnome org
> > http://mail.gnome.org/mailman/listinfo/release-team
> --
> Murray Cumming
> murrayc murrayc com
> www.murrayc.com
> www.openismus.com
> 
> _______________________________________________
> release-team mailing list
> release-team gnome org
> http://mail.gnome.org/mailman/listinfo/release-team
>