Re: [evolution-patches] Request for code freeze break - Exchange connector: #73218

[Murray Cumming <murrayc murrayc com>]

On Mon, 2005-03-07 at 10:20 -0700, Sushma Rai wrote:
> Yes, It fixes the bug reported.
> And this code wouldn't add any new defects.

I am still not very convinced that this has been tested enough. It's not
enough that it fixes the bug and that you don't _expect_ it to add new
defects.

But hopefully this only affects the "subscribing to other users'
folders" functionality. And if that doesn't work without this patch then
it can't get worse than that.

1 of 2 necessary approvals.

> 
> Thanks,
> Sushma.
> 
> >>> Murray Cumming <murrayc murrayc com> 03/07/05 22:23 PM >>>
> On Mon, 2005-03-07 at 01:53 -0700, Sushma Rai wrote:
> > Hi,
> > 
> > This patch fixes issues with subscribing to other 
> > user's folder.
> > 
> > This patch includes fix for modality issue,
> > retreiveing the user information, and also
> > displaying the username entry in the dialog, 
> > because of which subscribing to other user's
> > folders was not working.
> 
> How much have you tested this? Are you confident that it does not
> introduce any new bugs?
> 
> > Can this be committed to gnome-2-10 branch?
> > 
> > Thanks,
> > Sushma.
> > 
> > 
> > 
> > >>> Sarfraaz Ahmed <asarfraaz novell com> 03/07/05 13:51 PM >>>
> > (Guess this never reached the lists. So mailing again)
> > 
> > Looks fine.
> > 
> > -- Sarfraaz
> > 
> > On Sat, 2005-03-05 at 14:41 +0530, Sushma Rai wrote:
> > 
> > > Hi,
> > > 
> > > This is the fix for failure during subscribing to other user's 
> > > folders.
> > > 
> > > Please review,
> > > Sushma.
> > > 
> > > 
> > > 
> > > 
> > 
> > _______________________________________________
> > release-team mailing list
> > release-team gnome org
> > http://mail.gnome.org/mailman/listinfo/release-team
-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com