Re: [evolution-patches] Fix for 71733 (signature editor should set focus on title field)



Comitted into HEAD. Thanks!
��� Harry

Not Zed wrote:

Sure.� For head only.

On Wed, 2005-03-02 at 11:38 +0800, Harry Lu wrote:
 Hi, 
     Attached is the patch for 71733 (if we want to fix it). Please  
 review it. 
     Thanks! 
        Harry 
    
text/plain attachment (sig.diff)
 Index: ChangeLog 
 =================================================================== 
 RCS file: /cvs/gnome/evolution/mail/ChangeLog,v 
 retrieving revision 1.3598 
 diff -u -r1.3598 ChangeLog 
 --- ChangeLog	1 Mar 2005 06:17:19 -0000	1.3598 
 +++ ChangeLog	2 Mar 2005 03:35:37 -0000 
 @@ -1,3 +1,10 @@ 
 +2005-03-02  Harry Lu <harry lu sun com> 
 + 
 +	Fix for 71733. 
 + 
 +	* mail-signature-editor.c: (mail_signature_editor): if is_new, 
 +	let name_entry get the focus. 
 + 
  2005-02-28  JP Rosevear  <jpr novell com> 
   
  	* em-utils.c (em_utils_configure_account): pass in accountDruid 
 Index: mail-signature-editor.c 
 =================================================================== 
 RCS file: /cvs/gnome/evolution/mail/mail-signature-editor.c,v 
 retrieving revision 1.41 
 diff -u -r1.41 mail-signature-editor.c 
 --- mail-signature-editor.c	12 Jan 2005 02:20:53 -0000	1.41 
 +++ mail-signature-editor.c	2 Mar 2005 03:35:39 -0000 
 @@ -431,7 +431,11 @@ 
  	gtk_widget_show (GTK_WIDGET (editor->win)); 
  	gtk_widget_show (GTK_WIDGET (editor->control)); 
  	 
 -	CORBA_exception_init (&ev); 
 -	GNOME_GtkHTML_Editor_Engine_runCommand (editor->engine, "grab-focus", &ev); 
 -	CORBA_exception_free (&ev); 
 +	if (is_new) 
 +		gtk_widget_grab_focus (editor->name_entry); 
 +	else { 
 +		CORBA_exception_init (&ev); 
 +		GNOME_GtkHTML_Editor_Engine_runCommand (editor->engine, "grab-focus", &ev); 
 +		CORBA_exception_free (&ev); 
 +	} 
  } 
    


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]