Re: [evolution-patches] 71373 Re-enabling first run wizard

[Not Zed <notzed ximian com>]

it applied, compiled, and ran once, i say its ok to commit

On Mon, 2005-02-28 at 19:08 -0500, JP Rosevear wrote:
> On Mon, 2005-02-28 at 10:14 -0500, JP Rosevear wrote:
> > On Mon, 2005-02-28 at 13:41 +0800, Not Zed wrote:
> > > 
> > > Well do you have the patch?
> > 
> > A patch for the two small issues? No.  A patch was attached to the mail
> > 3 minutes before this though with the big updates.
>
> Oh, I guess you meant that startup-wizard.c was missing.  Not sure why
> that was since it was in the last one and other files in the dir are
> there.  New patch attached.
>
> > > I suspect #1 is window manager, and/or the fact it all runs in the
> > > main thread.
> > 
> > Seems to work ok
>
> "in 2.0".
>
> The cause actually appears to be the fact that e-config.c sets the type
> hint to DIALOG.  I set it to NORMAL (which the old wizard did), however
> e_config_create_window calls gtk_widget_show on the window so it has no
> affect in my code.  All the places that use em-account-editor also call
> gtk_widget_show on the config window, as do addressbook uses.  Calendar
> uses do not though so that would also have to be fixed if we removed the
> e-config.c gtk_widget_show call. Alternatively I could just hide the
> druid during the import which might make more sense anyhow since the
> user already hit apply.
>
> > > #2 i dont know, i'd probably have to step it.
> > 
> > I'd sent mail to meeks on friday, just got a response this morning I'll
> > grok through.
>
> Talked to meeks and federico today, it appears to be a bonobo or
> socket/plug issue propogating the state.  Seems minor given the
> circumstances i describe (in fact if you subsequently leave the
> importers page and then return to it a third time without causing a
> dialog rebuild, the control is sensitized properly).
>
> -JP