Re: [evolution-patches] Patches to fix bug 309079



Minor things - use k&r style braces (it is explained in HACKING), and
you dont need to cast to GObject anymore for g_object_unref, it takes a
void * (this isn't a problem; just a suggestion).

Can you commit?  If so, fix those and go for it, otherwise someone
whomever commits it can fix them (no need to send a new patch).

*poke* Calendar maintainers, where are you?  This is your job!

On Mon, 2005-06-27 at 10:58 -0400, Mark G. Adams wrote:
> Greetings all.
> 
> While working on fixing bug #274032 (PDA sync doesn't work on FC4), I
> came across a couple of memory leaks in the evolution data server while
> running gpilotd under valgrind.
> 
> The attached patches fix those two memory leaks, as well as providing a
> changelog entry. They are also attached to
> http://bugzilla.gnome.org/show_bug.cgi?id=309079 where I originally
> reported this.
> 
> The first patch fixes the leak where we create a uid in
> cal_object_created_cb and cal_add_timezone_cb in
> calendar/libecal/e-cal.c, but then never free the uid.
> 
> The second patch fixes the leak where build_change_list in
> calendar/libecal/e-cal-listener.c calls e_cal_component_new () to create
> new components, but then never frees them.
> 
> //Mark
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]