Re: [evolution-patches] Patch for bug# 302460

[lviren <lviren novell com>]

Harish,
	I have made changes in the change-log.


Thanks,
viren. 

On Fri, 2005-06-17 at 09:38 +0530, Harish Krishnaswamy wrote:
> Looks good. 
> May be you would like to make the ChangeLogs a bit more concise :)
> 
> Thanks,
> Harish
> 
> On Fri, 2005-06-10 at 21:45 +0530, lviren wrote:
> > hi,
> > 
> >    I have attached the patch for bug# 302460, which prevents evolution
> > from crashing when you double click on day/work-week view while it's in
> > edit mode.
> > 
> > Thanks,
> > Viren
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

Index: gui/e-day-view.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-day-view.c,v
retrieving revision 1.275
diff -u -p -w -r1.275 e-day-view.c
--- gui/e-day-view.c	13 Jun 2005 08:30:30 -0000	1.275
+++ gui/e-day-view.c	17 Jun 2005 05:30:47 -0000
@@ -3267,13 +3267,18 @@ e_day_view_on_event_double_click (EDayVi
 		event = &g_array_index (day_view->events[day], EDayViewEvent,
 					event_num);
 
-	e_day_view_stop_editing_event (day_view);
-
-    
-	attendee_prop = icalcomponent_get_first_property (event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY);
-	e_calendar_view_edit_appointment (E_CALENDAR_VIEW (day_view),
+        if (day == day_view->editing_event_day
+	                    && event_num == day_view->editing_event_num
+        	            && icalcomponent_get_current_property (event->comp_data->icalcomp)) {
+        	attendee_prop = icalcomponent_get_first_property (event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY)
+;
+        	e_calendar_view_edit_appointment (day_view,
 				     event->comp_data->client, 
 				     event->comp_data->icalcomp, attendee_prop ? TRUE:FALSE);
+ 	} else    
+		e_calendar_view_edit_appointment (day_view,
+				event->comp_data->client,
+			        event->comp_data->icalcomp, FALSE);
 }
 
 static void
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2745
diff -u -p -w -r1.2745 ChangeLog
--- ChangeLog	13 Jun 2005 08:30:30 -0000	1.2745
+++ ChangeLog	17 Jun 2005 05:30:55 -0000
@@ -1,3 +1,9 @@
+2005-06-17  Viren.l <lviren novell com>
+
+	* gui/e-day-view.c (e_day_view_on_event_double_click):
+	  use icalcomponent_get_current_property and invoke e_calendar_view_edit_appointment
+	  with appropriate parameters.	  
+
 2005-06-13  Jedy Wang  <jedy wang sun com>
 
 	We need compare backend for long events too.