Re: [evolution-patches] fix for bug #127526



Umm, sorry for messing you around here, but we already had a patch for
this.  It was implemented as a plugin - we were just waiting for
copyright assignment.

I asked Jonathan for this some time ago but never got a followup (or it
got lost in my inbox).  I'll cc him and see what he has to say about it.

I'm really sorry, I thought i'd seen this before, but I guess I wasn't
really on the ball last night when this mail went past.

 Michael

On Wed, 2005-06-08 at 21:57 +0300, Mohammad DAMT wrote:
> On Rab, 2005-06-08 at 20:37 +0800, Not Zed wrote:
> > We already have a 'dont ask this again' widget code, it is based on
> > e-error.  You must use that.  Look at what the other questions do.
> > Absolutely no need to write a whole new piece of code to do the same
> > thing!
> 
> Hi,
> 
> this is the updated patch using em_utils_prompt_user()
> thanks
> 
--- Begin Message ---
Jonathan,

I'm pretty happy with this, but to finally accept it we'll need the copyright assigned.

See here:

http://forge.novell.com/modules/xoopsfaq/?cat_id=30#q61

Thanks,
Michael

On Thu, 2005-03-24 at 16:34 +0200, Jonathan Dieter wrote:
Okay, I've removed the 'ask default' option, and created a gconf 
schema.  I also prefixed all public symbols with 
org_gnome_default_mailer, though after removing the 'ask default' 
option, the only public symbol left was the check_default() function.  
Let me know if there's anything else you think should be changed.

Not Zed wrote:

>
>
> Looks prety good at a first glance.
>
> I don't think we realy need the 'ask default' option in the mail 
> configuratin window though.  To me it just seems like clutter for an 
> option very few people, if anyone, would ever want to reset.  If they 
> do, there's always gconf-editor, assuming the key is properly 
> documented - you should add a gconf schemas file for this purpose 
> (although to be honest i don't know how you do that off the top of my 
> head).
>
> You should probably also prefix the public symbol names with the 
> org_gnome_xxxx stuff, to avoid name clashes (these will become public 
> symbols in the whole evolution application).  (i..e the callbacks).
>
> Thanks,
> Michael
>

--- End Message ---


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]