Re: [evolution-patches] Patch to fix DnD to composer




I really dont think there's a need to add a void getwidget() call to the
object which just sets data on the object.

Just set the data on the object when it (the widget) is created; then it
will always be available.

This will simplify the patch too.

Still add a comment saying what you're doing when you get the widget,
and how it is a hack.

On Thu, 2005-06-02 at 02:56 -0600, Srinivasa Ragavan wrote:
> Notzed,
> 
> I have attached the revised patch. It show the attachment bar when the attachments are added and removes when all the attachments are removed.
> 
> -Srini.
> 
> >>> Not Zed <notzed ximian com> 06/02/05 9:55 AM >>>
> 
> > Sorry I didnt know. I didnt know how to pass a pointer. Initially i
> > passed it as a string. I thought it as evil and passed as 'any '.
> > Since the name suggested generic :-). So ill revert back to 'String'. 
> 
> If you want to do any CORBA stuff you should read some background
> information on it.  Michaels suggested approach looks good, and it will
> fail-over properly if the stuff isn't in-proc.  Better than a pointer
> address which might just crash.
> 
> > Michael, i have made gtkhtml-editor as a widget and have it working as
> > well. But im not pretty confident on that. It works perfectly, except
> > some bonobo leaks. Still quite a few work pending. I would love to
> > make this better and use it in future. I have all the PersistStream,
> > File, EditorEngine converted a library.
> 
> I don't understand why you would need persist-stream etc.  You can
> probably just set the content directly, or have simple iterators to fill
> it up/extract it.
> 
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]