Re: [evolution-patches] Patch to fix DnD to composer

["Srinivasa Ragavan" <sragavan novell com>]

Notzed,

Sorry I didnt know. I didnt know how to pass a pointer. Initially i passed it as a string. I thought it as evil and passed as 'any '. Since the name suggested generic :-). So ill revert back to 'String'. 

Michael, i have made gtkhtml-editor as a widget and have it working as well. But im not pretty confident on that. It works perfectly, except some bonobo leaks. Still quite a few work pending. I would love to make this better and use it in future. I have all the PersistStream, File, EditorEngine converted a library.

Michael, ill check it in and also make the attachment bar visible, only when attachments are added.

Thanks
Srini.

>>> Not Zed <notzed ximian com> 06/01/05 6:18 AM >>>

Oh dear ... mate ... you just can't pass c types (i.e. gtkwidget's)
around through CORBA_any's!!!

I'm surprised this is even working, i guess it is only because orbit
short-circuits in-proc calls that it isn't trying to marshal or
demarshal this "rubbish" as an any object.

At least pass it as a string (i.e. "%p" the address of the object), and
put a gigantic comment saying how totally evil and unportable this is
and that nobody should ever use it.

The htmleditor *component* needs to be converted to a widget (or at
least, a library), not just the editor widget passed around.  This is a
really nasty hack, but its really not worth splitting hairs because it
fixes the problem for now and wont take a couple of man-weeks to write.

Can you also make the gigantic attachment box only show if there are
attachments now?  You can probably remove the redundant label entirely
too.

 Michael

PS cc'ing Meeks for his entertainment ;-)

>  
> +static CORBA_any *
> +impl_get_widget (PortableServer_Servant servant, CORBA_Environment *
> ev)
> +{
> +       EditorEngine *e = html_editor_engine_from_servant (servant);
> +       
> +       return (CORBA_any *) e->cd->html;
> +}


On Mon, 2005-05-30 at 01:48 -0600, Srinivasa Ragavan wrote:
> Hi,
> 
> I have attached the patch, which fixes the bug, when a url is dropped to the composer(gtkhtml) window, it pastes.
> 
> I added a new bonobo-interface to get the widget and listen for dnd signals. It currently pastes the dnd except, url, file, evo items (cal, contact, task).
> 
> The patch has two parts. One to evoltion and other to gtkhtml.
> Please review it.
> 
> Thanks
> Srini.
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches