[evolution-patches] Patch for bug#246225 , bug#246227
- From: Arulanandan P <arulanandan gmail com>
- To: evolution-patches lists ximian com, pjessica novell com, partha <sparthasarathi novell com>, eugene oconnor sun com
- Cc:
- Subject: [evolution-patches] Patch for bug#246225 , bug#246227
- Date: Sat, 30 Jul 2005 13:20:39 +0530
Hi,
i have attached the patch for the bugs # 246225 and 246227 with
changelog . This fixes the UI suggestions for the "Advanced Search"
and "Save Search" dialogs .
Please review it .
bye
arulanandan
Index: filter-rule.c
===================================================================
RCS file: /cvs/gnome/evolution/filter/filter-rule.c,v
retrieving revision 1.68
diff -u -p -r1.68 filter-rule.c
--- filter-rule.c 16 May 2005 06:14:34 -0000 1.68
+++ filter-rule.c 30 Jul 2005 07:37:08 -0000
@@ -777,6 +777,7 @@ get_widget (FilterRule *fr, struct _Rule
GtkWidget *add, *label, *name, *w;
GtkWidget *omenu, *menu, *item;
GtkWidget *scrolledwindow;
+ GtkWidget *columntitle;
GtkObject *hadj, *vadj;
GList *l;
gchar *text;
@@ -788,7 +789,7 @@ get_widget (FilterRule *fr, struct _Rule
rule parts need to be a vbox */
vbox = gtk_vbox_new (FALSE, 6);
- label = gtk_label_new_with_mnemonic (_("_Rule name:"));
+ label = gtk_label_new_with_mnemonic (_("_Search name:"));
name = gtk_entry_new ();
gtk_label_set_mnemonic_widget (label, name);
@@ -816,7 +817,7 @@ get_widget (FilterRule *fr, struct _Rule
gtk_box_pack_start (GTK_BOX (vbox), hbox, FALSE, FALSE, 0);
gtk_widget_show (hbox);
- text = g_strdup_printf("<b>%s</b>", _("If"));
+ text = g_strdup_printf("<b>%s</b>", _("Find items that meet the following criteria"));
label = gtk_label_new (text);
gtk_label_set_use_markup (GTK_LABEL (label), TRUE);
gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
@@ -855,9 +856,9 @@ get_widget (FilterRule *fr, struct _Rule
gtk_box_pack_start (GTK_BOX (hbox), add, FALSE, FALSE, 0);
if (f->flags & RULE_CONTEXT_GROUPING) {
- const char *thread_types[] = { N_("if all criteria are met"), N_("if any criteria are met") };
+ const char *thread_types[] = { N_("If all criteria are met"), N_("If any criteria are met") };
- label = gtk_label_new (_("Execute actions"));
+ label = gtk_label_new (_("Find items:"));
menu = gtk_menu_new ();
for (i=0;i<2;i++) {
@@ -901,6 +902,25 @@ get_widget (FilterRule *fr, struct _Rule
}
gtk_box_pack_start (GTK_BOX (inframe), hbox, FALSE, FALSE, 3);
+
+ // adds title to the columns in the table of criteria : Field , Condition , Value
+ columntitle = gtk_hbox_new(TRUE,0);
+ label = gtk_label_new(g_strdup_printf("<b>%s</b>","Field")) ;
+ gtk_label_set_use_markup(GTK_LABEL(label),TRUE);
+ gtk_box_pack_start (GTK_BOX (columntitle), label, FALSE, FALSE, 6);
+
+ label = gtk_label_new(g_strdup_printf("<b>%s</b>","Condition") );
+ gtk_label_set_use_markup(GTK_LABEL(label),TRUE);
+ gtk_box_pack_start( GTK_BOX(columntitle) , label , FALSE ,FALSE ,6);
+
+ label = gtk_label_new(g_strdup_printf("<b>%s</b>","Value"));
+ gtk_label_set_use_markup(GTK_LABEL(label),TRUE);
+ gtk_box_pack_start(GTK_BOX(columntitle) , label , FALSE , FALSE , 6 );
+
+ label = gtk_label_new (" ");
+ gtk_box_pack_start(GTK_BOX(columntitle), label , FALSE , FALSE , 6);
+
+ gtk_box_pack_start(GTK_BOX(inframe), columntitle, FALSE, FALSE,0);// packs the column titles to the inframe
l = fr->parts;
i = 0;
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/filter/ChangeLog,v
retrieving revision 1.425
diff -u -p -r1.425 ChangeLog
--- ChangeLog 16 May 2005 06:14:34 -0000 1.425
+++ ChangeLog 30 Jul 2005 07:49:48 -0000
@@ -1,3 +1,9 @@
+2005-07-30 Arulanandan P <arulanandan gmail com>
+
+ * filter-rule.c : Added the UI suggestions for "Advanced search" and "Save search"
+
+ * Fixes bugs #246225 , #246227
+
2005-05-16 Not Zed <NotZed Ximian com>
* moved e-error to e-util
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]